Skip to content

Conversation

muzimuzhi
Copy link
Contributor

@muzimuzhi muzimuzhi commented Sep 4, 2023

Why:

Closes: #27989

What's being changed (if available, include any code snippets, screenshots, or gifs):

Several trailing and a single beginning newlines inside markdown code blocks are removed.

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are:
.devcontainer/**
.github/actions-scripts/**
.github/workflows/**
.github/CODEOWNERS
assets/fonts/**
data/graphql/**
Dockerfile*
src/**
lib/redirects/**
package*.json
scripts/**
content/actions/deployment/security-hardening-your-deployments/**

You'll need to revert all of the files you changed in that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Sep 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/using-workflows/events-that-trigger-workflows.md fpt
ghec
ghes@ 3.10 3.9 3.8 3.7 3.6
ghae
fpt
ghec
ghes@ 3.10 3.9 3.8 3.7 3.6
ghae
admin/administering-your-instance/command-line-utilities.md ghes@ 3.10 3.9 3.8 3.7 3.6
ghes@ 3.10 3.9 3.8 3.7 3.6
code-security/code-scanning/using-codeql-code-scanning-with-your-existing-ci-system/migrating-from-the-codeql-runner-to-codeql-cli.md fpt
ghec
ghes@ 3.10 3.9 3.8 3.7 3.6
ghae
fpt
ghec
ghes@ 3.10 3.9 3.8 3.7 3.6
ghae
code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file.md fpt
ghec
ghes@ 3.10 3.9 3.8 3.7 3.6
fpt
ghec
ghes@ 3.10 3.9 3.8 3.7 3.6
code-security/supply-chain-security/understanding-your-software-supply-chain/using-the-dependency-submission-api.md fpt
ghec
ghes@ 3.10 3.9 3.8 3.7
fpt
ghec
ghes@ 3.10 3.9 3.8 3.7
codespaces/setting-up-your-project-for-codespaces/adding-a-dev-container-configuration/setting-up-your-java-project-for-codespaces.md fpt
ghec
fpt
ghec
issues/planning-and-tracking-with-projects/automating-your-project/automating-projects-using-actions.md fpt
ghec
ghes@ 3.10 3.9 3.8
fpt
ghec
ghes@ 3.10 3.9 3.8
migrations/using-github-enterprise-importer/migrating-organizations-with-github-enterprise-importer/migrating-organizations-from-githubcom-to-github-enterprise-cloud.md fpt
ghec
ghes@ 3.10 3.9 3.8 3.7 3.6
fpt
ghec
ghes@ 3.10 3.9 3.8 3.7 3.6

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@muzimuzhi
Copy link
Contributor Author

Please note that changes to the data directory will not show up in this table.

I've also reviewed all the pages affected by the changes to data dir.

@cmwilson21
Copy link
Contributor

@muzimuzhi Thanks for opening an issue and submitting a PR! We appreciate the details you've provided 👍

I'll get this triaged for review! ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Sep 5, 2023
Copy link
Contributor

@subatoi subatoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this (and for raising an issue)—it's very much appreciated ✨

@subatoi subatoi added this pull request to the merge queue Sep 6, 2023
Merged via the queue into github:main with commit fd6d3b4 Sep 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@muzimuzhi muzimuzhi deleted the trailing-newline branch September 6, 2023 15:33
Ambassadormathismathews

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Superfluous newlines found in some code blocks
4 participants