Skip to content

Conversation

nathanweeks
Copy link
Contributor

@nathanweeks nathanweeks commented Sep 6, 2023

Why:

Closes: #28019

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

@welcome
Copy link

welcome bot commented Sep 6, 2023

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Sep 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
codespaces/overview.md fpt
ghec
fpt
ghec

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@cmwilson21
Copy link
Contributor

@nathanweeks Thanks so much for submitting a PR! I'll get this triaged for review ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review copilot Content related to GitHub Copilot and removed triage Do not begin working on this issue until triaged by the team labels Sep 6, 2023
@subatoi
Copy link
Contributor

subatoi commented Sep 7, 2023

@nathanweeks Many thanks for raising this PR—

Unfortunately, when we said (yesterday) that the minimum spec was for 4 GB, in theory you shouldn't be seeing codespaces with that any more—and when we checked today that was the case. This is as a result of a very recent change as described in https://github.blog/2023-08-31-how-github-reduces-costs-with-upgraded-codespaces/

It seems likely the current text may have been added prematurely, but it is in any case correct. Please accept our apologies for the confusion caused and thank you for your interest in the docs: you were absolutely right to raise the issue.

@nathanweeks
Copy link
Contributor Author

@subatoi Thanks for the explanation---and the great news! I was wondering why the 2-core codespace was 4 GB, and the 4-core codespace was 16 GB. I just checked today, and indeed the memory for the 2-core codespace has increased from 4 GB to 8 GB. I'll close the issue & PR.

(as an aside, a separate issue is perhaps the use of the word "core": the 2-"core" instance appears to have a single processor core with 2 hardware threads (SMT) per lscpu; "logical cores", "vCPUs", "logical CPUs", or just "CPUs" would be more standard terminology IMHO, though admittedly a large documentation lift...)

@nathanweeks nathanweeks closed this Sep 7, 2023
@nathanweeks nathanweeks deleted the patch-1 branch September 7, 2023 13:34
@subatoi
Copy link
Contributor

subatoi commented Sep 7, 2023

@nathanweeks Thank you! I'll certainly pass that feedback on to the relevant team. Apologies again for the confusion around this particular issue, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team copilot Content related to GitHub Copilot waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2-core codespace currently has 4 GB RAM (instead of 8 GB)
3 participants