-
Notifications
You must be signed in to change notification settings - Fork 63.1k
feat: add note that clarifies the process of using Gravatar profile #28580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add note that clarifies the process of using Gravatar profile #28580
Conversation
@CBID2 Thanks for submitting a PR with this fix! I'll get this triaged for review ⚡ However, in the meantime, would you be able to update the PR a bit? In the docs, we use variables to refer to GitHub and different products. You can find more info about using variables here. Could you update any usage of the name GitHub in your PR to use the reusable variable? You can see an example of this variable in use on line 26 for reference. 👍 |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
Hi @CBID2, thanks for the contribution! In addition to the change @cmwilson21 identified above, would you be able to move your note so that it is the final paragraph in the intro section of "Changing your profile picture"? (This section starts on line 30). Because there's already a note here, and we don't generally use multiple notes in a row, you could also change your text to be a regular paragraph. Thank you! ✨ |
Made the changes @cmwilson21 and @isaacmbrown! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates @CBID2! Left a few more suggestions
...g-up-and-managing-your-github-profile/customizing-your-profile/personalizing-your-profile.md
Outdated
Show resolved
Hide resolved
| {% octicon "lock" aria-label="The lock icon" %} | **Security Bug Bounty Hunter** | If you helped out hunting down security vulnerabilities, you'll get a Security Bug Bounty Hunter badge on your profile. For more information about the {% data variables.product.prodname_dotcom %} Security program, see [{% data variables.product.prodname_dotcom %} Security](https://bounty.github.com/). | | ||
| {% octicon "mortar-board" aria-label="The mortar-board icon" %} | **{% data variables.product.prodname_dotcom %} Campus Expert** | If you participate in the {% data variables.product.prodname_campus_program %}, you will get a {% data variables.product.prodname_dotcom %} Campus Expert badge on your profile. For more information about the Campus Experts program, see [Campus Experts](https://education.github.com/experts). | | ||
| {% octicon "shield" aria-label="The shield icon" %} | **Security advisory credit** | If a security advisory you submit to the [{% data variables.product.prodname_dotcom %} Advisory Database](https://github.com/advisories) is accepted, you'll get a Security advisory credit badge on your profile. For more information about {% data variables.product.prodname_dotcom %} Security Advisories, see [{% data variables.product.prodname_dotcom %} Security Advisories](/code-security/security-advisories/working-with-repository-security-advisories/about-repository-security-advisories). | | ||
| Badge | Program | Description | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CBID2 Were these changes deliberate? We have a linter that checks for trailing spaces so I think it would be best to reset these changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @isaacmbrown! :) I use markdownlint to check for syntax errors. It helps me gain a better understanding of where to make the change. However, I'll make the necessary changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CBID2 Were these changes deliberate? We have a linter that checks for trailing spaces so I think it would be best to reset these changes.
Made the change @isaacmbrown! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @CBID2, I could still see the added whitespace in the tables so I pushed up a fix to revert the tables to how they were before. If you check the "Files changed" tab now you'll just see the note you added in the diff, which is what we want.
If you're ever in a situation again where you need to revert some of the changes to a file, I used the following command.
git checkout --patch main -- content/account-and-profile/setting-up-and-managing-your-github-profile/customizing-your-profile/personalizing-your-profile.md
This lets you interactively choose which of your changes to the file you want to keep, and which changes you want to reset to how they are on main
.
Co-authored-by: Isaac Brown <101839405+isaacmbrown@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @CBID2, this is good to go! 🚀
Yay! :) Thanks @isaacmbrown! :) The tests passed so can you merge my PR now? The auto merge did not work for some reason. |
@isaacmbrown, the graphql test failed, causing my PR to be removed from the queue list. How can I fix this problem? |
Hi @CBID2, this will be a temporary internal issue with our workflows, so no need to do anything from your side. I'll investigate the issue; I believe we're already looking into it |
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
@CBID2 Thanks for picking up this issue! If you are interested in finding other open issues, checkout our help wanted section to find open issues ready for work. 💖 |
Can I try this one @cmwilson21: #28557 |
@CBID2 Absolutely! We don't assign issues, but you are welcome to submit a PR against anything labelled |
Why:
This pull request adds a note on how Gravatar profile pictures work on GitHub and how to update them. This addition helps users gain a better understanding of this process.
Closes:
Closes #28553
What's being changed (if available, include any code snippets, screenshots, or gifs):
Check off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.
data
directory.For content changes, I have completed the self-review checklist.