Skip to content

docs: update article about alert syntax #29043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 11, 2023
Merged

docs: update article about alert syntax #29043

merged 7 commits into from
Oct 11, 2023

Conversation

Rizina
Copy link
Contributor

@Rizina Rizina commented Oct 10, 2023 •
edited
Loading

Why:

Closes: #27919

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

  • For content changes, I have completed the self-review checklist.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Oct 10, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2023 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax.md fpt
ghec
ghes@ 3.10 3.9 3.8 3.7 3.6
ghae
 fpt
ghec
ghes@ 3.10 3.9 3.8 3.7 3.6
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@steveward steveward added content This issue or pull request belongs to the Docs Content team get started Content related to "Getting Started" doc set and removed triage Do not begin working on this issue until triaged by the team labels Oct 10, 2023
@steveward
Copy link
Member

Thanks for the PR @Rizina! I'll get this triaged for review. ⚡

sabrowning1
sabrowning1 requested changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@sabrowning1 sabrowning1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋🏼 @Rizina, thanks again for opening this PR! I've left some feedback below; let me know if you have any questions 🙂

Rizina and others added 4 commits October 11, 2023 22:11
@Rizina @sabrowning1
Update content/get-started/writing-on-github/getting-started-with-wri…
34af0ef 
…ting-and-formatting-on-github/basic-writing-and-formatting-syntax.md

Co-authored-by: Sam Browning <106113886+sabrowning1@users.noreply.github.com>
@Rizina @sabrowning1
Update content/get-started/writing-on-github/getting-started-with-wri…
1e559b6 
…ting-and-formatting-on-github/basic-writing-and-formatting-syntax.md

Co-authored-by: Sam Browning <106113886+sabrowning1@users.noreply.github.com>
@Rizina @sabrowning1
Update content/get-started/writing-on-github/getting-started-with-wri…
110f48b 
…ting-and-formatting-on-github/basic-writing-and-formatting-syntax.md

Co-authored-by: Sam Browning <106113886+sabrowning1@users.noreply.github.com>
@Rizina @sabrowning1
Update content/get-started/writing-on-github/getting-started-with-wri…
ff9c2fd 
…ting-and-formatting-on-github/basic-writing-and-formatting-syntax.md

Co-authored-by: Sam Browning <106113886+sabrowning1@users.noreply.github.com>
@Rizina Rizina requested a review from sabrowning1 October 11, 2023 16:28
sabrowning1
sabrowning1 approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@sabrowning1 sabrowning1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making those changes @Rizina! This looks great, I'll get it merged shortly 🚀

@sabrowning1 sabrowning1 added the hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! label Oct 11, 2023
@sabrowning1 sabrowning1 enabled auto-merge October 11, 2023 17:45
@sabrowning1 sabrowning1 disabled auto-merge October 11, 2023 18:52
@sabrowning1 sabrowning1 added this pull request to the merge queue Oct 11, 2023
Merged via the queue into github:main with commit b11dd6d Oct 11, 2023
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@commit-lint commit-lint bot mentioned this pull request Oct 19, 2023
Merged
@Rizina Rizina deleted the docs/27919-alert-info-updates branch October 28, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabrowning1 sabrowning1 sabrowning1 approved these changes

Assignees
No one assigned
Labels
content This issue or pull request belongs to the Docs Content team get started Content related to "Getting Started" doc set hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Correct Alerts syntax or clarify context where they are expected to work
3 participants
@Rizina @steveward @sabrowning1