-
Notifications
You must be signed in to change notification settings - Fork 63.1k
[Actions] Document authentication for service containers #29915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Document how to authenticate with private registries and DockerHub when pulling images for service containers.
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
@ndench Thank you for opening a PR and linking it to your issue! ✨ I'll get this triaged for review! ⚡ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ndench - Great change, many thanks for adding this! 👍
Just one suggestion - which you can click to commit.
content/actions/using-containerized-services/about-service-containers.md
Outdated
Show resolved
Hide resolved
…tainers.md I'm going to go ahead and commit this suggestion.
Merging this now |
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Document how to authenticate with private registries and DockerHub when pulling images for service containers.
Why:
The documentation for service containers doesn't currently show how to specify credentials.
However, there's a blog post from 2020 showing how to do it.
Closes: #29914
What's being changed (if available, include any code snippets, screenshots, or gifs):
The docs don't show how to specify credentials when using service containers. Credentials may be necessary to pull images from private registries or to authenticate with DockerHub in order to increase rate limits.
Check off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.
data
directory.For content changes, I have completed the self-review checklist.