Skip to content

Conversation

ndench
Copy link
Contributor

@ndench ndench commented Nov 13, 2023

Document how to authenticate with private registries and DockerHub when pulling images for service containers.

Why:

The documentation for service containers doesn't currently show how to specify credentials.
However, there's a blog post from 2020 showing how to do it.

Closes: #29914

What's being changed (if available, include any code snippets, screenshots, or gifs):

The docs don't show how to specify credentials when using service containers. Credentials may be necessary to pull images from private registries or to authenticate with DockerHub in order to increase rate limits.

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

Document how to authenticate with private registries and DockerHub when pulling images  for service containers.
Copy link

welcome bot commented Nov 13, 2023

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Nov 13, 2023
Copy link
Contributor

github-actions bot commented Nov 13, 2023

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/using-containerized-services/about-service-containers.md fpt
ghec
ghes@ 3.11 3.10 3.9 3.8
fpt
ghec
ghes@ 3.11 3.10 3.9 3.8

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

@cmwilson21
Copy link
Contributor

@ndench Thank you for opening a PR and linking it to your issue! ✨

I'll get this triaged for review! ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Nov 13, 2023
Copy link
Contributor

@hubwriter hubwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ndench - Great change, many thanks for adding this! 👍

Just one suggestion - which you can click to commit.

…tainers.md


I'm going to go ahead and commit this suggestion.
@hubwriter
Copy link
Contributor

Merging this now

@hubwriter hubwriter enabled auto-merge February 5, 2024 10:38
@hubwriter hubwriter added this pull request to the merge queue Feb 5, 2024
Merged via the queue into github:main with commit f22ad0b Feb 5, 2024
Copy link
Contributor

github-actions bot commented Feb 5, 2024

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specifying credentials for service containers
3 participants