Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Allow Enterprise access over regular HTTP #159

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
6 participants

takai commented Apr 5, 2012

Now only HTTPS scheme is allow to checkout pull request. We use GitHub Enterprise with non-SSL environment. This patch allows hub to checkout pull reuqest with HTTP.

Member

mislav commented Apr 5, 2012

The existing hub.protocol config is for git cloning, not API access. But I see what you mean: I didn't anticipate API access that is not over HTTPS (unless your ruby is not compiled with OpenSSL and it can't use HTTPS, then it falls back to HTTP). I'll try to do something about this.

takai commented Apr 6, 2012

I see, thanks 😄

Can this patch still be merged? It would be very helpful.

Member

mislav commented Jun 15, 2012

Yes, it would be useful, but I don't have an idea how to configure a specific Enterprise host to be accessed over HTTP instead HTTPS. As I said in my previous comment, hub.protocol config is not for this purpose. I have to think about this.

The github_api gem allows you to specify the whole host URL, could hub not do the same? Thanks!

@mislav mislav referenced this pull request in git-merge/hack-day May 10, 2013

Closed

Improving `pull-request` and other features of hub CLI tool #1

kumavis commented May 14, 2013

👍 This issue is preventing me from integrating hub into my daily workflow. Very interested in a fix.

Yeraze commented Jan 13, 2014

Likewise.. I just found hub, and it looks awesome, but I can't deploy it in my organization until this is fixed.

Member

mislav commented Feb 28, 2014

This is now possible via protocol option in ~/.config/hub. 7944d63

Release pending.

@mislav mislav closed this Feb 28, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment