Skip to content

Conversation

muan
Copy link
Contributor

@muan muan commented Nov 4, 2019

This is to support github/github's content type for HTML fragment (text/html; fragment) so we can move away from XHR checks with a clear path forward.

I've also added a special case for accept="*/*" in 6dc7867 which I'm 😓 not too sure about.

@muan muan requested a review from a team November 4, 2019 22:02
Copy link
Contributor

@dgraham dgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

Copy link
Contributor

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I agree with @dgraham's review notes as well.

@muan muan merged commit 834f1e5 into master Nov 5, 2019
@muan muan deleted the accept branch November 5, 2019 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants