Skip to content

Conversation

@yzguy
Copy link
Contributor

@yzguy yzguy commented Dec 10, 2018

Adds requested feature from #304

This maps an OctoDNS ALIAS record to DnsMadeEasy's ANAME record. In looking at their ANAME support, they allow IP addresses as values for ANAME records, which seems silly as then it's just an A record at that point, so I did not handle that case, if it's common enough I guess we could.

Example OctoDNS config

---
? ''
: - ttl: 1800
    type: ALIAS
    value: www.example.com.
  - type: MX

OctoDNS will dump all ANAME records to being ALIAS records
OctoDNS will apply all ALIAS records as being ANAME records

/cc @fahanson

Copy link
Contributor

@ross ross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Geneally 👍, I'd recommend peaking at https://github.com/github/octodns/pull/305/files as I just ran into a problem with CloudflareProvider that I'd bet will happen here now with the translated type.

@yzguy
Copy link
Contributor Author

yzguy commented Dec 10, 2018

Refactored, fixed the update issue.

I handled the same issue in the DnsMadeEasyClient, it transforms all ANAME's to ALIAS, and then before creating changing ALIAS to ANAME. Pretty clean, there's kind of a loop for fixing record weirdness (relative versus absolute)

@ross ross merged commit 90b8268 into octodns:master Dec 10, 2018
@yzguy yzguy deleted the dnsmadeeasy_aname branch December 10, 2018 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants