This repository was archived by the owner on Apr 1, 2025. It is now read-only.
Fix DiffTreeVertexDiffTerm definition to be a valid protobuf object. #180
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We define the DiffTreeVertex protobuf message like so:
This is turned into two Haskell types, a toplevel
DiffTreeVertex
typeand a
DiffTreeVertexDiffTerm
type that represents the anonymousoneof
type. Said types looked like so:This is the wrong representation, as it neglects to account for the
fact that options could be added to the
diff_term
stanza. A sum typedoes not provide enough constructors to handle the case of when none
of
deleted
,inserted
,replaced
etc. isJust
anything. A morecorrect definition follows:
This patch applies the above change, using
-XPatternSynonyms
toprovide backwards-compatible API shims. Though this changes JSON
output format (through the
ToJSON
instance), it should have nobearing on backwards compatibility in protobuf objects, since there is
no way to consume diff trees as protobufs as of this writing.
Fixes #168.