add TabContainerChange event class #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
TabContainerChangeEvent, rather than usingCustomEventwhich is not a best practice, and existed mostly becauseEventused to not be extensible.Using
TabContainerChangedEventwe can put properties directly on the event, rather than the awkwarddetailprop.In addition to this, I've added the
onTabContainerChangeandonTabContainerChangedprops to the element, which allow the "old school" assignment of the property to add an event listener. This allows frameworks like React to seamlessly use these events too. We did this in github/relative-time-element#246