Improve apache virtual host configuration #50
Conversation
Allow downloading attachments from gitlab. Configure ProxyPass, to allow access to gitlab from anywhere. DocumentRoot should lead to public-folder of gitlab.
|
Great. Really really great. |
|
+1 |
|
r+ but I think document root should match the one in the official installation guide, that is /home/git/gitlab/public. |
| @@ -8,12 +8,21 @@ | |||
| #RewriteCond %{SERVER_PORT} ^80$ | |||
| #RewriteRule ^(.*)$ https://%{SERVER_NAME}$1 [L,R] | |||
|
|
|||
| ProxyPass /uploads ! | |||
There was a problem hiding this comment.
I also added ProxyPass /error ! after this line to fix the display of HTTP errors coming from apache. Without this, apache tries to load its error page from e.g. /error/HTTP_BAD_GATEWAY.html.var but that gets proxied to unicorn, which then shows a 404 instead of the actual error.
|
+1; I added a note to the diff about also excluding /error from the proxy so apache HTTP errors are handled properly rather than ending up at unicorn's 404 page. |
to documented public-directory of gitlab.
|
Thanks @adaugherity and @axilleas , updated the commit with your enhancements. |
Beware that adding `ProxyPass /uploads !` would be a security issue, since uploads are publicly available without any authentification by default. See: https://github.com/gitlabhq/gitlabhq/issues/348#issuecomment-21682402
|
Thank you, implemented manually in above commit, as I am working on a new directory structure. |
Allow downloading attachments from gitlab.
Configure ProxyPass, to allow access to gitlab from anywhere.
DocumentRoot should lead to public-folder of gitlab.