Adding support+tests for annotated tags. #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is strange. The test passes on my laptop and my workstation (Ruby 1.9.3 & Git 2.0). I'm also able to use "git rev-parse tag_name^{}" on my production gitlab server using "/opt/gitlab/embedded/bin/git" (Git 1.8.5.3). I'll look at this again later tonight. |
…on the temporary repo.
|
OK, CI build passed. Just waiting for feedback now. Thanks! |
|
@jvanbaarsen No problem! I already put in most of the work to allow you to create annotated tags from the UI too: https://github.com/asedge/gitlabhq/commits/annotated_tags. That PR should be filed soon. |
dzaporozhets
added a commit
that referenced
this pull request
Jul 15, 2014
Adding support+tests for annotated tags.
maxlazio
pushed a commit
that referenced
this pull request
Jun 5, 2019
Go implementation for git-upload-archive Closes #162 See merge request gitlab-org/gitlab-shell!307
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feedback is always appreciated!