Custom post-receive hooks can't be called #194
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -27,5 +27,6 @@ def update_redis | |||
| puts "GitLab: An unexpected error occurred (redis-cli returned #{$?.exitstatus})." | |||
| exit 1 | |||
| end | |||
| return true | |||
|
merging this one into #190 |
maxlazio
pushed a commit
that referenced
this pull request
Jun 27, 2019
Add Makefile for easier building and testing Closes #194 See merge request gitlab-org/gitlab-shell!310
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #192 and not yet taken into account in #190
The update_redis method was missing a "return true" when the
operation is succesful. Without it, any custom post-receive
hooks that come after the call to GitlabPostReceive.exec.
I tested this change in a local copy and it fixes the issue.