Allow custom update hooks #71
Conversation
I know the prefered way is using web hooks. But we also have some bash scripts which we realy need. For example we want things like rsync to trigger, doing this using webhooks would require me to write an HTTP app for this. The same is true for post-receive hooks, we would like to force server side syntax checking and style checks. I understand that this is not maintained by gitlab therefore call all scripts located in the update.d
|
The |
|
@castovoid you are right, I will make a change |
|
Thank you for your pull request. We have thought about this and we think it would be better if users that need custom |
|
@jacobvosmaer Thanks. Actually I still think this could be very useful since it will not break gitlabs-shell when updating while providing users a standard way of chaining custom hooks. If you think this is really not needed I would like to document it what would be the preferred way? |
|
I agree with @netdata. Putting our hook logic inside the |
|
@jacobvosmaer I have also rebased this MR would you needed it |
|
@jacobvosmaer Is this a definitive decision? Just want to hammer once more since I don't see anything wrong with supporting this officially, everyone who wants to customize this hook has the same issue:
If it helps I willing to make the required documentation inside the gitlab project. Just waiting on your final answer Thanks |
|
@netdata thank you for pointing to some more of the history of this idea. We are still discussing this; I will let you know about the outcome. |
|
+1 to a way to support this, our use case would be to be able to "git push --mirror REMOTE" , and web hooks just don't cut it. |
|
+1 this is important. Why would I lost the power of have the repo in my own machine, if I can't put per repo hooks ? |
|
Also see #85; +1's welcome. |
|
👍 +1 |
|
Support for custom scripts as hooks is THE main feature I am evaluating before selecting a new git hosting solution. Forcing folks to write an HTTP API just to handle these is silly. That this feature request has not been handled and repeated pull requests have been either closed or are still sitting open is the main concern I have considering a switch to Gitlab. |
I know the prefered way is using web hooks.
But we also have some bash scripts which we realy need. For example we
want things like rsync to trigger, doing this using webhooks would
require me to write an HTTP app for this.
The same is true for post-receive hooks, we would like to force server
side syntax checking and style checks.
I understand that this is not maintained by gitlab therefore call all
scripts located in the update.d