Optimization of file history

Author: vsizov

CHANGELOG

@@ -1,3 +1,6 @@
+v 7.2.9
+  - Optimization of file history method
+
 v 7.2.8
   - Ignore symbolic refs that point to deleted branches (Stan Hu)
 

Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    gitlab_git (7.2.8)
+    gitlab_git (7.2.9)
       activesupport (~> 4.0)
       charlock_holmes (~> 0.6)
       gitlab-linguist (~> 3.0)
@@ -49,7 +49,7 @@ GEM
       guard (>= 1.1)
       rspec (~> 2.11)
     i18n (0.7.0)
-    json (1.8.2)
+    json (1.8.3)
     listen (1.0.2)
       rb-fsevent (>= 0.9.3)
       rb-inotify (>= 0.9)

VERSION

@@ -1 +1 @@
-7.2.8
+7.2.9

lib/gitlab_git/repository.rb

@@ -278,10 +278,23 @@ def log(options)
         options[:offset] ||= 0
         actual_ref = options[:ref] || root_ref
         sha = sha_from_ref(actual_ref)
-        build_log(sha, options)
-      rescue Rugged::OdbError, Rugged::InvalidError, Rugged::ReferenceError
-        # Return an empty array if the ref wasn't found
-        []
+        repo = options[:repo]
+
+        cmd = %W(git -C #{path} log)
+        cmd << %W(-n #{options[:limit].to_i})
+        cmd << %W(--skip=#{options[:offset].to_i})
+        cmd << %W(--follow) if options[:follow]
+        cmd << %W(--no-merges) if options[:skip_merges]
+        cmd << sha
+        cmd << %W(-- #{options[:path]}) if options[:path]
+
+        raw_output = IO.popen(cmd.flatten) {|io| io.read }
+
+        log = raw_output.scan(/commit\ ([0-9a-f]{40})/).flatten.map do |c|
+          Rugged::Commit.new(rugged, c)
+        end
+
+        log.is_a?(Array) ? log : []
       end
 
       def sha_from_ref(ref)
@@ -837,46 +850,6 @@ def parse_gitmodules(commit, content)
         results
       end
 
-      # Return an array of log commits, given an SHA hash and a hash of
-      # options.
-      def build_log(sha, options)
-        # Instantiate a Walker and add the SHA hash
-        walker = Rugged::Walker.new(rugged)
-        walker.push(sha)
-
-        commits = []
-        skipped = 0
-        current_path = options[:path]
-        current_path = nil if current_path == ''
-
-        limit = options[:limit].to_i
-        offset = options[:offset].to_i
-        skip_merges = options[:skip_merges]
-
-        walker.sorting(Rugged::SORT_DATE)
-        walker.each do |c|
-          break if limit > 0 && commits.length >= limit
-
-          if skip_merges
-            # Skip merge commits
-            next if c.parents.length > 1
-          end
-
-          if !current_path ||
-            commit_touches_path?(c, current_path, options[:follow], walker)
-
-            # This is a commit we care about, unless we haven't skipped enough
-            # yet
-            skipped += 1
-            commits.push(c) if skipped > offset
-          end
-        end
-
-        walker.reset
-
-        commits
-      end
-
       # Returns true if +commit+ introduced changes to +path+, using commit
       # trees to make that determination.  Uses the history simplification
       # rules that `git log` uses by default, where a commit is omitted if it