This repository was archived by the owner on May 12, 2018. It is now read-only.
Typo herlper -> helper. #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,7 +1,7 @@ | |||
| # Gitlab::Git::Repository is a wrapper around native Grit::Repository object | |||
| # We dont want to use grit objects inside app/ | |||
| # It helps us easily migrate to rugged in future | |||
| require_relative 'encoding_herlper' | |||
| require_relative 'encoding_helper' | |||
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
cirosantilli
force-pushed
the
typo-herlper
branch
from
69a840a to
12a764d
Compare
| @@ -16,7 +16,7 @@ | |||
|
|
|||
| # Gitlab::Git | |||
| require_relative "gitlab_git/popen" | |||
| require_relative "gitlab_git/encoding_herlper" | |||
| require_relative 'gitlab_git/encoding_helper' | |||
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
|
nice typo :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe there is a reason for this, in that case I'm very curious to know =)