This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upConversation
houndci-bot
reviewed
Sep 14, 2014
| @@ -1,7 +1,7 @@ | ||
| # Gitlab::Git::Repository is a wrapper around native Grit::Repository object | ||
| # We dont want to use grit objects inside app/ | ||
| # It helps us easily migrate to rugged in future | ||
| require_relative 'encoding_herlper' | ||
| require_relative 'encoding_helper' |
This comment has been minimized.
This comment has been minimized.
houndci-bot
Sep 14, 2014
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
This comment has been minimized.
This comment has been minimized.
coveralls
commented
Sep 14, 2014
cirosantilli
force-pushed the
cirosantilli:typo-herlper
branch
from
69a840a
to
12a764d
Sep 14, 2014
houndci-bot
reviewed
Sep 14, 2014
| @@ -16,7 +16,7 @@ | ||
| # Gitlab::Git | ||
| require_relative "gitlab_git/popen" | ||
| require_relative "gitlab_git/encoding_herlper" | ||
| require_relative 'gitlab_git/encoding_helper' |
This comment has been minimized.
This comment has been minimized.
houndci-bot
Sep 14, 2014
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
This comment has been minimized.
This comment has been minimized.
coveralls
commented
Sep 14, 2014
added a commit
that referenced
this pull request
Sep 15, 2014
dzaporozhets
merged commit 732baeb
into
gitlabhq:master
Sep 15, 2014
1 check passed
continuous-integration/travis-ci
The Travis CI build passed
Details
This comment has been minimized.
This comment has been minimized.
|
nice typo :) |
cirosantilli
deleted the
cirosantilli:typo-herlper
branch
Sep 15, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
cirosantilli commentedSep 14, 2014
Maybe there is a reason for this, in that case I'm very curious to know =)