Skip to content

Conversation

riyad
Copy link
Contributor

@riyad riyad commented Aug 2, 2012

Allows use of Github Flavored Markdown to link to

  • issues (#123)
  • merge request (!123)
  • commits (1234567)
  • team members (@foo)
  • snippets ($123)

in

  • commit messages
  • notes/comments/wall posts
  • issues
  • merge requests
  • milestones
  • wiki pages

and fulfills much of the promise of #527.

Please test this before merging and come back with any issues.
The links are marked up nicely so individual styling can be applied.
For now it will just show a tooltip with some info about the linked item when hovering over the link.

What is not included:

  • linking to notes/attachments (let's say it's complicated)
  • fancy styling (ideas and help appreciated, especially help)
  • making it more discoverable and adding docs/help
  • automated actions or notifications (this will be tough)

@riyad
Copy link
Contributor Author

riyad commented Aug 2, 2012

and here is the screen shot ... but the changes are subtle. :)

@icholy
Copy link

icholy commented Aug 2, 2012

+1 woot!

@dzaporozhets
Copy link
Contributor

@riyad I'm going to spend few hours for this today. I'll provide a feedback

@IsNull
Copy link

IsNull commented Aug 4, 2012

+1 Very nice!

@dzaporozhets
Copy link
Contributor

played with it. pretty good :)

Also we need:

  • check there is no perfomance decrease
  • make link in comment form with help popup containing gitlab markup examples

I'll continue review on next weekend. Or someone from gitlab core will do it earlier.

PS: Great work :)

@vsizov
Copy link
Contributor

vsizov commented Aug 5, 2012

First of all, I would like to thank you.
There is a little problem http://i.imgur.com/ZG5dc.png
Can you fix that?

@riyad
Copy link
Contributor Author

riyad commented Aug 5, 2012

@randx how would you measure the performance impact?
@vsizov I'll look into it :)

@optikfluffel
Copy link
Contributor

nice one :D

@riyad
Copy link
Contributor Author

riyad commented Aug 6, 2012

I've merged with master and fixed the failing tests @vsizov was running into.
It seems the @project variable is not set in all circumstances (e.g. notification mails) which leads GFM to fail. It will now raise an exception if that is the case to make finding the error more obvious.
Also I updated the notification mails to start using the GFM notation.

@dzaporozhets
Copy link
Contributor

@riyad lets create a separate helper like GitalbFlavoredMarkdownHelper instead keeping all stuff in app herlper

@riyad riyad mentioned this pull request Aug 7, 2012
dzaporozhets added a commit that referenced this pull request Aug 7, 2012
@dzaporozhets dzaporozhets merged commit 72c6be2 into gitlabhq:master Aug 7, 2012
@dzaporozhets
Copy link
Contributor

lets merge it. tired to wait :)

@riyad thank you!!!

@optikfluffel
Copy link
Contributor

+1

On 07.08.2012, at 21:17, Dmitriy Zaporozhets notifications@github.com wrote:

lets merge it. tired to wait :)

@riyad thank you!!!


Reply to this email directly or view it on GitHub.

@dzaporozhets
Copy link
Contributor

Help page added 34ba4e1

@riyad
Copy link
Contributor Author

riyad commented Aug 9, 2012

@randx cool thx :D

@vrybas
Copy link

vrybas commented Oct 2, 2012

@riyad What do you mean by "snippets"? The Gists? Can you please attach snippet in your reply. I can't get it working.

@riyad
Copy link
Contributor Author

riyad commented Oct 3, 2012

@vrybas GitHub calls them Gists. In GitLab they are called "Snippets". You can access them from your project dashboard from the second row of tabs.

Do you see the "Snippets" tab?
GitLab Project Dashboard

@vrybas
Copy link

vrybas commented Oct 3, 2012

@riyad got it now, thanks

dzaporozhets added a commit that referenced this pull request May 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

7 participants