Project Template for Project Creation #7069

pixel-shock · 2014-06-03T16:59:59Z

Hi,

this is a new PR for this one: #6127
It's now possible to create project-template and create projects from these templates.

Hope you like it ...

Conflicts: Gemfile

houndci-bot · 2014-06-03T17:00:07Z

app/controllers/admin/project_templates_controller.rb

@@ -0,0 +1,55 @@
+class Admin::ProjectTemplatesController < Admin::ApplicationController


Use nested module/class definitions instead of compact style.

This comment can be ignored

houndci-bot · 2014-06-03T17:00:16Z

config/initializers/1_settings.rb

@@ -100,6 +100,8 @@ def verify_constant(modul, current, default)
 Settings.gitlab.default_projects_features['snippets']       = false if Settings.gitlab.default_projects_features['snippets'].nil?
 Settings.gitlab.default_projects_features['visibility_level']    = Settings.send(:verify_constant, Gitlab::VisibilityLevel, Settings.gitlab.default_projects_features['visibility_level'], Gitlab::VisibilityLevel::PRIVATE)
 Settings.gitlab['repository_downloads_path'] = File.absolute_path(Settings.gitlab['repository_downloads_path'] || 'tmp/repositories', Rails.root)
+Settings.gitlab['templates_path'] = File.join(File.absolute_path(Settings.gitlab['templates_path'] || Settings.gitlab['user_home'] + '/gitlab-templates'),'/')


Line is too long. [158/80]
Space missing after comma.

dosire · 2014-06-04T07:20:38Z

@pixel-shock Thanks for your contribution but the same comment as in 6127 applies:
#6127 (comment)
I propose to start from simple init with README. Without templates

Also see the contribution guidelines:
https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md
Please keep the change in a single MR as small as possible. If you want to contribute a large feature think very hard what the minimum viable change is. Can you split functionality? Can you only submit the backend/API code? Can you start with a very simple UI? The smaller a MR is the more likely it is it will be merged, after that you can send more MR's to enhance it.

We can always enhance it later but each MR has to be as small as possible. Please stick to the AMR conditions in http://feedback.gitlab.com/forums/176466-general/suggestions/3797854-create-empty-repo-on-project-creation for the first MR

pixel-shock · 2014-06-04T07:24:34Z

@dosire

Hi,

so the small "version" of this MR is this I think:

1.) simple checkbox at project creation ("init" [yes/no])
2.) create a README after init the repo, commit and push it

Is this correct?

EDIT: Sorry for the large MR, but I thought I should do it as "feature complete" as possible to avoid much work for you 😄

dosire · 2014-06-04T07:56:44Z

@pixel-shock Yes, I check with @randx and that would be an awesome minimal size for the first MR.

dosire · 2014-06-04T07:57:26Z

@pixel-shock And no problem about trying to make it feature complete, it is maybe counter intuitive but smaller steps make everything go faster.

jvanbaarsen · 2014-06-04T20:19:22Z

app/models/project_template.rb

+  default_value_for :template_name_length, 100
+  default_value_for :template_description_length, 750
+
+  attr_accessor :template_name_length, :template_description_length


@randx Since we currently use Rails4, maybe we should start using the strong params in new classes?

jvanbaarsen · 2014-06-04T20:32:34Z

@pixel-shock I jumped true the code, and put some comments everywhere, but didn't realise that @dosire had already responded 💃

So if you're going to create a new MR, please ignore my comments :-)

pixel-shock · 2014-06-04T20:50:09Z

@jvanbaarsen thx for your quick email-reply 😉
I'll try to fix this stuff asap (hopefully tomorrow) and if this stuff is fixed, I'll do another branch for the minimal initialization ...

THX for your comments and advices ...

abargutu · 2014-06-25T08:55:23Z

it works for gitlab 7?

pixel-shock · 2014-06-25T08:57:19Z

Hi,

sorry, didn’t tested it yet … I’ve spend a lot of time at work at the moment, so I can’t test it in GL7 :(

Cheers
Tino

Am 25.06.2014 um 10:55 schrieb abargutu notifications@github.com:

it works for gitlab 7?

—
Reply to this email directly or view it on GitHub.

abargutu · 2014-06-25T09:03:08Z

could you sendme the link where i can see the definitly changes because it is a little confuse
please
thanks in advance

pixel-shock · 2014-06-25T09:05:45Z

do you mean my changes in the LG code?

#7069

scroll down and you can see all my changes.

Am 25.06.2014 um 11:03 schrieb abargutu notifications@github.com:

could you sendme the link where i can see the definitly changes because it is a little confuse
please
thanks in advance

—
Reply to this email directly or view it on GitHub.

abargutu · 2014-06-25T09:14:26Z

yes
i'm looking this one https://github.com/gitlabhq/gitlabhq/pull/7069/files is that correct?
i think the last updates are here https://github.com/gitlabhq/gitlabhq/pull/7069/files

thanks a lot!!!!
i'm going to check it in gitlab 7

abargutu · 2014-06-25T13:34:16Z

oooooooooooooooooooooHHHHH
i create a readme.txt and zip it and upload to poject template and it is ready to use
but when i create a repo and selectting projetc template and push create repo still apears the 'how to create repo manually' :((((

jvanbaarsen · 2014-08-02T10:36:34Z

@pixel-shock Is this PR ready for review?

pixel-shock · 2014-08-04T09:38:20Z

@jvanbaarsen Hi, in principle it is ready for review (functionality) but I have to fix some code-style issues first and I have to merge it into the 7.1 branch I think.
At the moment I have a lot to do - so my spare-time is very overloaded :-(

jvanbaarsen · 2014-08-04T09:39:34Z

Ok! Thanks for your reply!
--
Jeroen van Baarsen

On 4 augustus 2014 at 11:38:49, Tino W. (notifications@github.com) wrote:

@jvanbaarsen Hi, in principle it is ready for review (functionality) but I have to fix some code-style issues first and I have to merge it into the 7.1 branch I think.
At the moment I have a lot to do - so my spare-time is very overloaded :-(

—
Reply to this email directly or view it on GitHub.

ksavoie · 2014-08-26T16:33:27Z

Hi everyone, excuse my ignorance on how project updates work, but has this feature (create empty repo on project creation) been committed to the latest version of GitLab as I could really benifit? I'm running 7.2 of GitLab CE and do not see how to opt to create a empty repo on new project within the Web UI.
Thanks for any assistance.

bbodenmiller · 2014-09-17T06:53:06Z

@pixel-shock really hope you can get a very basic init repo functionality added soon. Need this for #7759.

dblessing · 2014-10-24T03:11:19Z

@pixel-shock If you don't have time to pursue this at the moment, do you mind if we close it? You can always resurrect when you have time.

vicendominguez · 2014-10-31T11:02:18Z

Oh man! is there other way then? (to create the git project with a readme or a project-template)

dblessing · 2014-11-11T14:23:39Z

This merge request has been closed because a request for more information has not been reacted to for more than 2 weeks. If you respond and conform to the merge request guidelines in our contributing guidelines we will reopen this merge request.

pixel-shock and others added 5 commits April 11, 2014 05:35

added possiblity to create project templates

7ee684f

merged gitlabhq master into branch

c5bd77e

Merge remote-tracking branch 'upstream/master' into repo_init

4316761

Conflicts: Gemfile

template init changes

1abdc11

added some little tests

e20fdb5

houndci-bot reviewed Jun 3, 2014
View reviewed changes

jvanbaarsen reviewed Jun 4, 2014
View reviewed changes

cirosantilli mentioned this pull request Jul 12, 2014

Suggest compatible templates for endorsed engine. booktree/booktree#13

Open

jvanbaarsen added the Awaiting developer action/feedback label Aug 2, 2014

bbodenmiller mentioned this pull request Sep 17, 2014

Proof of concept: recommend that user adds README, LICENSE, and .gitignore files #7759

Closed

5 tasks

dblessing closed this Nov 11, 2014

pixel-shock deleted the repo_init branch April 7, 2015 12:01

		@@ -0,0 +1,55 @@
		class Admin::ProjectTemplatesController < Admin::ApplicationController

Project Template for Project Creation #7069

Project Template for Project Creation #7069

Uh oh!

Conversation

pixel-shock commented Jun 3, 2014

Uh oh!

houndci-bot Jun 3, 2014

Choose a reason for hiding this comment

Uh oh!

jvanbaarsen Jun 4, 2014

Choose a reason for hiding this comment

Uh oh!

houndci-bot Jun 3, 2014

Choose a reason for hiding this comment

Uh oh!

dosire commented Jun 4, 2014

Uh oh!

pixel-shock commented Jun 4, 2014

Uh oh!

dosire commented Jun 4, 2014

Uh oh!

dosire commented Jun 4, 2014

Uh oh!

jvanbaarsen Jun 4, 2014

Choose a reason for hiding this comment

Uh oh!

jvanbaarsen commented Jun 4, 2014

Uh oh!

pixel-shock commented Jun 4, 2014

Uh oh!

abargutu commented Jun 25, 2014

Uh oh!

pixel-shock commented Jun 25, 2014

Uh oh!

abargutu commented Jun 25, 2014

Uh oh!

pixel-shock commented Jun 25, 2014

Uh oh!

abargutu commented Jun 25, 2014

Uh oh!

abargutu commented Jun 25, 2014

Uh oh!

jvanbaarsen commented Aug 2, 2014

Uh oh!

pixel-shock commented Aug 4, 2014

Uh oh!

jvanbaarsen commented Aug 4, 2014

Uh oh!

ksavoie commented Aug 26, 2014

Uh oh!

bbodenmiller commented Sep 17, 2014

Uh oh!

dblessing commented Oct 24, 2014

Uh oh!

vicendominguez commented Oct 31, 2014

Uh oh!

dblessing commented Nov 11, 2014

Uh oh!

Uh oh!