resource/gitlab_repository_file: Fix check if file exists during read. Closes #1260 #1277
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RicePatrick
approved these changes
Oct 15, 2022
There was a problem hiding this comment.
Hey @timofurrer - Added the "closes" link to your initial description, otherwise LGTM. I'll approve here, and if you're good with closing it, go ahead and merge. Just in case you didn't want to close the issue, I'll leave this open for now :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason the check if the file exists was matching some text in the error message - however it should check the status code, like everywhere else.
Closes #1260