feat: add Emails on Push service (#607) #1305
Conversation
github-actions
bot
added
dependencies
documentation
provider
resource
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome @christian-sahlmann 👋
It looks like this is your first submission to the Terraform GitLab Provider! If you haven’t already done so, please make sure you have checked out our CONTRIBUTING.md guide to make sure your contribution has all the necessary elements in place for a successful approval.
Thanks again, and welcome to the community! 😃
christian-sahlmann
force-pushed
the
emails-on-push
branch
3 times, most recently
from
0b7ee68 to
645001f
Compare
|
@christian-sahlmann thanks for the contribution 🎉 Could you please rebase onto the latest main (see #1304)? |
christian-sahlmann
force-pushed
the
emails-on-push
branch
from
645001f to
eb90d2c
Compare
There was a problem hiding this comment.
@christian-sahlmann already looks pretty solid. I've left a few comments 🏓
internal/provider/resource_gitlab_service_emails_on_push_test.go
Outdated
Show resolved
Hide resolved
christian-sahlmann
force-pushed
the
emails-on-push
branch
from
eb90d2c to
6b995f2
Compare
christian-sahlmann
force-pushed
the
emails-on-push
branch
from
6b995f2 to
37dea53
Compare
|
@timofurrer, thanks for the great review and for being gentle with a go beginner ;) I hope I adressed all comments properly. |
christian-sahlmann
force-pushed
the
emails-on-push
branch
from
37dea53 to
d9ca5f2
Compare
christian-sahlmann
force-pushed
the
emails-on-push
branch
from
d9ca5f2 to
0ce7c19
Compare
There was a problem hiding this comment.
@christian-sahlmann thanks for the fast update - it looks ready to merge 🎉
... and you did great - especially as a Go beginner 💪 keep it up 🌮
No description provided.