Skip to content

Conversation

timofurrer
Copy link
Member

@timofurrer timofurrer commented Feb 11, 2022

It's currently sporadically failing, because of the upstream bug here: https://gitlab.com/gitlab-org/gitlab/-/issues/333296

I've also refactored the withEnvironmentScopeFilter function into a separate file.

@timofurrer timofurrer requested a review from armsnyder February 11, 2022 13:13
@timofurrer timofurrer self-assigned this Feb 11, 2022
@github-actions github-actions bot added provider resource Adds or modifies a resource tests size/M labels Feb 11, 2022
This currently sporadically failing, because of the upstream bug here: https://gitlab.com/gitlab-org/gitlab/-/issues/333296
Copy link
Collaborator

@armsnyder armsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, ack the new disabled test

@timofurrer timofurrer merged commit 8f2d1a0 into gitlabhq:main Feb 14, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

provider resource Adds or modifies a resource size/M tests

Development

Successfully merging this pull request may close these issues.

2 participants