-
Notifications
You must be signed in to change notification settings - Fork 318
feat: Add rule_type parameter to merge_request_approval_rule #913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add rule_type parameter to merge_request_approval_rule #913
Conversation
This is working in the API, and is necessary in order to enable Eligible Approvers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @petrmvala 👋
It looks like this is your first submission to the Terraform GitLab Provider! If you haven’t already done so, please make sure you have checked out our CONTRIBUTING.md guide to make sure your contribution has all the necessary elements in place for a successful approval.
Thanks again, and welcome to the community! 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very promising, nice work! I've left a few minor comments.
internal/provider/resource_gitlab_project_approval_rule_test.go
Outdated
Show resolved
Hide resolved
Based on MR suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
@DonNicoJs @armsnyder I've merged this because all checks passed and I've assigned the |
This functionality has been released in v3.12.0 of the Terraform GitLab Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue. Thank you! |
This is working in the API, and is necessary in order to enable
Eligible Approvers.
Description
#904
PR Checklist Acknowledgement
//lintignore
comments were copied from existing code. (Linter rules are meant to be enforced on new code.)