Skip to content

Conversation

petrmvala
Copy link
Contributor

@petrmvala petrmvala commented Mar 3, 2022

This is working in the API, and is necessary in order to enable
Eligible Approvers.

Description

#904

PR Checklist Acknowledgement

  • I acknowledge that all of the following items are true, where applicable:
    • Resource attributes match 1:1 the names and structure of the API resource in the GitLab API documentation.
    • Examples are updated with:
      • A *.tf file for the resource/s with at least one usage example
      • A *.sh file for the resource/s with an import example (if applicable)
    • New resources have at minimum a basic test with three steps:
      • Create the resource
      • Update the attributes
      • Import the resource
    • No new //lintignore comments were copied from existing code. (Linter rules are meant to be enforced on new code.)

This is working in the API, and is necessary in order to enable
Eligible Approvers.
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @petrmvala 👋

It looks like this is your first submission to the Terraform GitLab Provider! If you haven’t already done so, please make sure you have checked out our CONTRIBUTING.md guide to make sure your contribution has all the necessary elements in place for a successful approval.

Thanks again, and welcome to the community! 😃

@timofurrer timofurrer linked an issue Mar 3, 2022 that may be closed by this pull request
1 task
@timofurrer timofurrer added this to the v3.12.0 milestone Mar 3, 2022
@timofurrer timofurrer self-requested a review March 3, 2022 12:52
Copy link
Member

@timofurrer timofurrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very promising, nice work! I've left a few minor comments.

Petr Vála added 2 commits March 3, 2022 14:29
Copy link
Member

@timofurrer timofurrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@timofurrer timofurrer merged commit a5a62fb into gitlabhq:main Mar 4, 2022
@timofurrer
Copy link
Member

@DonNicoJs @armsnyder I've merged this because all checks passed and I've assigned the safe to test label (this is an EE feature) - However, seems like EE tests were not executed and main is now failing :'( Not sure what went wrong here. But I'll try to make main pass again ;)

@github-actions
Copy link

github-actions bot commented Mar 8, 2022

This functionality has been released in v3.12.0 of the Terraform GitLab Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue. Thank you!

@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Development

Successfully merging this pull request may close these issues.

Add any_approver option for gitlab_project_approval_rule

2 participants