Use single GET endpoints to retrieve GAT and PAT
#989
Conversation
|
@timofurrer Is there any GitHub action we can use that is similar to the !RemindMe 1 week/1 month/etc. of reddit. Where there can be a post/notification to look at a PR/issue when a certain period of time is reached? This would be useful for when functionality in the provider is blocked by a functionality that is scheduled to be released in a future GitLab version so as not to forget about something like this PR |
|
@Shocktrooper a quick search revealed at least one: https://github.com/agrc/reminder-action Though I'm not really sure if it's worth the maintenance - GitLab releases are always at the same day of the month, every month, thus it's kinda hard to miss - and I've created a milestone where to assign these issues / PRs. I think that gives us an additional benefit over the reminder, because we can actually filter them :) |
|
@timofurrer The milestones seem like a good way to go. I was just thinking for some issues where maybe the functionality is scheduled a long way down the line/not at all vs within a few months. They would be reminders to check if the upstream API has been released such as for an issue like this where GitLab has not added the functionality at the time and we might want to check in say like 6 months |
|
This would break compatibility to GitLab < 14.10 |
github-actions
bot
added
the
merge-conflict
|
This pull request has merge conflicts. Please rebase your branch onto |
|
Marking this pull request as stale due to 30 days of inactivity. If this pull request receives no comments in the next 14 days it will be closed. Maintainers can also remove the To help this pull request get reviewed, please check that it is rebased onto the latest and is passing automated checks. It also helps if you could reference an issue that the pull request resolves, and create one if it doesn't exist. |
|
Marking this pull request as stale due to 30 days of inactivity. If this pull request receives no comments in the next 14 days it will be closed. Maintainers can also remove the To help this pull request get reviewed, please check that it is rebased onto the latest and is passing automated checks. It also helps if you could reference an issue that the pull request resolves, and create one if it doesn't exist. |
|
Marking this pull request as stale due to 30 days of inactivity. If this pull request receives no comments in the next 14 days it will be closed. Maintainers can also remove the To help this pull request get reviewed, please check that it is rebased onto the latest and is passing automated checks. It also helps if you could reference an issue that the pull request resolves, and create one if it doesn't exist. |
|
@timofurrer Is this unblocked now that 14.10 has been released and the prerequisite PR has been merged? |
timofurrer
force-pushed
the
feature/get-pat-gat
branch
from
a371c22 to
c253023
Compare
github-actions
bot
removed
the
merge-conflict
|
Conflicts are resolved. Thank you! 😀 |
timofurrer
force-pushed
the
feature/get-pat-gat
branch
from
c253023 to
50a1d06
Compare
|
No other comments from reviews, thanks @timofurrer and @Shocktrooper ! |
|
This functionality has been released in v3.17.0 of the Terraform GitLab Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue. Thank you! |
3 participants
We should be able to merge this :)