Skip to content

Conversation

peter279k
Copy link
Contributor

Changed log

  • These assertions should use assertSame to make assert equals strictly.

@GrahamCampbell
Copy link
Member

I think it's a bug that those functions are not returning integers.

@peter279k
Copy link
Contributor Author

It looks like the problematic codes are available on the this class.

And the dump result of $vars is as follows:

...
array(4) {
  [0] =>
  string(7) "-0,0 +1"
  [1] =>
  string(1) "0"
  [2] =>
  string(1) "0"
  [3] =>
  string(1) "1"
}
...

It seems that some variables should be convert string type to int:

$rangeOldStart = (int) $vars[1];
$rangeOldCount = (int) $vars[2];
$rangeNewStart = (int) $vars[3];

@peter279k peter279k closed this Dec 9, 2020
peter279k added a commit to open-source-contributions/gitlib that referenced this pull request Dec 9, 2020
@peter279k peter279k deleted the test_enhancement branch December 9, 2020 17:53
peter279k added a commit to open-source-contributions/gitlib that referenced this pull request Dec 10, 2020
GrahamCampbell added a commit that referenced this pull request Dec 29, 2020
Co-authored-by: Graham Campbell <GrahamCampbell@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants