Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the bug for counter variable type on PR #183 #184

Merged
merged 2 commits into from Dec 29, 2020

Conversation

peter279k
Copy link
Contributor

@peter279k peter279k commented Dec 9, 2020

Fix bugs about counter variable type and it's about PR #183.

@GrahamCampbell
Copy link
Member

Thanks. Could you make the test strict too, please?

@peter279k
Copy link
Contributor Author

done :).

@peter279k
Copy link
Contributor Author

Hi @GrahamCampbell, please look at latest commit on this PR. Thanks.

@GrahamCampbell
Copy link
Member

Sorry, the reason for the delay is that you unchecked the box that allows me to make corrections to your PR. Can you merge open-source-contributions#1?

@GrahamCampbell GrahamCampbell merged commit e7a9ddd into gitonomy:1.2 Dec 29, 2020
@GrahamCampbell
Copy link
Member

Thanks.

@peter279k peter279k deleted the fix_bug_pr_183 branch December 29, 2020 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants