fixup broken profile update; prepare for calling UpdateUser instead of partial updates

Author: AlexTugarev

components/dashboard/src/user-settings/Account.tsx

@@ -57,6 +57,7 @@ export default function Account() {
         }
 
         await updateUser.mutateAsync({
+            fullName: profileState.name,
             additionalData: {
                 profile: profileState,
             },

components/gitpod-protocol/src/protocol.ts

@@ -194,23 +194,6 @@ export namespace User {
         };
     }
 
-    export function setProfile(user: User, profile: Profile): User {
-        user.fullName = profile.name;
-        user.avatarUrl = profile.avatarURL;
-
-        if (!user.additionalData) {
-            user.additionalData = {};
-        }
-        if (!user.additionalData.profile) {
-            user.additionalData.profile = {};
-        }
-        user.additionalData.profile.emailAddress = profile.email;
-        user.additionalData.profile.companyName = profile.company;
-        user.additionalData.profile.lastUpdatedDetailsNudge = new Date().toISOString();
-
-        return user;
-    }
-
     // TODO: refactor where this is referenced so it's more clearly tied to just analytics-tracking
     // Let other places rely on the ProfileDetails type since that's what we store
     // This is the profile data we send to our Segment analytics tracking pipeline