Skip to content

Fix JetBrains backend plugin not up-to-date for prebuilds #20123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Fix JetBrains backend plugin not up-to-date for prebuilds #20123

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions components/ide/jetbrains/launcher/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1172,22 +1172,26 @@ func linkRemotePlugin(launchCtx *LaunchContext) error {
remotePluginsFolder = launchCtx.backendDir + "/plugins"
}
remotePluginDir := remotePluginsFolder + "/gitpod-remote"
_, err := os.Stat(remotePluginDir)
if err == nil || !errors.Is(err, os.ErrNotExist) {
return nil
}
if err := os.MkdirAll(remotePluginsFolder, 0755); err != nil {
return err
}

// added for backwards compatibility, can be removed in the future
sourceDir := "/ide-desktop-plugins/gitpod-remote-" + os.Getenv("JETBRAINS_BACKEND_QUALIFIER")
_, err = os.Stat(sourceDir)
_, err := os.Stat(sourceDir)
if err == nil {
return os.Symlink(sourceDir, remotePluginDir)
return safeLink(sourceDir, remotePluginDir)
}

return os.Symlink("/ide-desktop-plugins/gitpod-remote", remotePluginDir)
return safeLink("/ide-desktop-plugins/gitpod-remote", remotePluginDir)
}

func safeLink(source, target string) error {
if _, err := os.Stat(target); err == nil {
// unlink the old symlink
_ = os.RemoveAll(target)
}
return os.Symlink(source, target)
}

// TODO(andreafalzetti): remove dir scanning once this is implemented https://youtrack.jetbrains.com/issue/GTW-2402/Rider-Open-Project-dialog-not-displaying-in-remote-dev
Expand Down
Loading