-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SINGE shell script and separation of GLG_Instance and Aggregate functions #37
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What changed in data1/tf.mat
? Can we avoid changing the input data in this pull request?
Do we want to still keep SCINGE_Example.m
or is that stale now? The main reason to keep it would be to give an example for users who want to run SINGE locally and directly through MATLAB instead of using the compiled code, right?
Can we rename SCINGE.m
and any other source files that use the old name in this pull request?
Do we want to change test cases to run standalone_SCINGE.sh
on the sample data? That's the primary workflow now. We could also test that and the compiled SCINGE_Example
.
We can run the equivalent of SINGE_Example.m by running the following command: Perhaps we can include the above in the README.md? |
Yes, let's add that command to the readme when we document how to use this new script and updated our input parameter descriptions. |
We still would like an example of how to run SINGE directly through MATLAB
…into config_changes
I finished a round of changes to the compile script, Dockerfile, and Docker-based tests. I'll see what errors appear when these tests run. I restored |
I had to specify the MATLAB runtime path in the standalone script so that it could find the runtime in the Docker container. Should we make that another argument to the script? The location will vary for different users. |
Yes. That's how it will handle currently. |
The new parameter parser broke the support for one of the date formats:
See https://travis-ci.com/gitter-lab/SINGE/builds/126320790#L698 |
No longer compile SINGE_Example Test the compiled SINGE_Test instead
@atuldeshpande it looks like the error here https://travis-ci.com/gitter-lab/SINGE/jobs/235318717#L989 is being caused by |
Closes #17
This pull request creates a shell script to emulate the standalone SINGE function which calls the GLG_Instance executable followed by Aggregate executable.
Requires compilation of the code/GLG_Instance.m and code/Aggregate.m. "v94" in the standalone_SCINGE.sh should be replaced by the name of the folder containing the runtime libraries.