Fix scrollbar in commit msg #387
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #350
Well I know that may not be the perfect solution, but a better fix itself would have to be inside
scrollbar.rs
anyway. This has to do with the way of how position of scrollbar is calculated, and changingmax
parameter ofdraw_scrollbar
function would change nothing as either the scrollbar would never reach the end, or there would be a lot of empty lines.This functionality would display scrollbar by default (which, regardless of this fix, is also the case with diff) and a simple check can prevent it from rendering.
What do you think?