Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Project.toml and tests #23

Merged
merged 6 commits into from
Jan 29, 2022
Merged

Adding Project.toml and tests #23

merged 6 commits into from
Jan 29, 2022

Conversation

GearsAD
Copy link
Contributor

@GearsAD GearsAD commented Jan 29, 2022

Hi @glesica,

We're having some issues because Neo4j.jl doesn't have a Project.toml with dependencies/compat. We've added this and testing, could you please review and merge if everything looks ok?

Adding @Affie

Thanks!

sam-globus and others added 6 commits January 28, 2022 15:05
I see that I'm using HTTP.jl 0.8, and I remember some issue with downstream compatibilities. I can't find exactly what the issue was, but I don't it would cause an issue if we support HTTP 0.8 as well.
@glesica
Copy link
Owner

glesica commented Jan 29, 2022

This looks good to me!

@glesica glesica merged commit e262b01 into glesica:master Jan 29, 2022
@GearsAD
Copy link
Contributor Author

GearsAD commented Jan 29, 2022

Great, thanks! Whenever convenient do you mind tagging it as a release?

I'm not sure if you have Julia Registrator installed on this repo, but it's a quick way to update the Julia registry with the latest release. If you create an issue with the content @JuliaRegistrator register it will do the rest to release v2.1.0 (currently set in Project.toml).

@glesica
Copy link
Owner

glesica commented Jan 30, 2022

OK, here's the issue... #24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants