dp: swdp_bitbang: fix missing reset pin error

maxd-nordic · mmahadevan108 · commit 4f85ce6eda93 · 2024-11-07T08:33:18.000-06:00
This patch fixes an issue where the reset pin is used even when it's
not given.

Signed-off-by: Maximilian Deubel &lt;maximilian.deubel@nordicsemi.no&gt;
diff --git a/drivers/dp/swdp_bitbang.c b/drivers/dp/swdp_bitbang.c
@@ -601,9 +601,11 @@ static int sw_port_on(const struct device *dev)
 		return ret;
 	}
 
-	ret = gpio_pin_configure_dt(&config->reset, GPIO_OUTPUT_ACTIVE);
-	if (ret) {
-		return ret;
+	if (config->reset.port) {
+		ret = gpio_pin_configure_dt(&config->reset, GPIO_OUTPUT_ACTIVE);
+		if (ret) {
+			return ret;
+		}
 	}
 
 	return 0;

Original file line number	Diff line number	Diff line change
`@@ -601,9 +601,11 @@ static int sw_port_on(const struct device *dev)`
`601`	`601`	`return ret;`
`602`	`602`	`}`
`603`	`603`
`604`		`- ret = gpio_pin_configure_dt(&config->reset, GPIO_OUTPUT_ACTIVE);`
`605`		`- if (ret) {`
`606`		`- return ret;`
	`604`	`+ if (config->reset.port) {`
	`605`	`+ ret = gpio_pin_configure_dt(&config->reset, GPIO_OUTPUT_ACTIVE);`
	`606`	`+ if (ret) {`
	`607`	`+ return ret;`
	`608`	`+ }`
`607`	`609`	`}`
`608`	`610`
`609`	`611`	`return 0;`