Skip to content

v0.10.30: audio frame in the opening header

Choose a tag to compare

@gnacho gnacho released this 05 Nov 22:54
· 31 commits to main since this release

The RTSP endpoint answers in milliseconds instead of half a minute.

Fixed

  • go2rtc probes a pipe source by waiting for one packet of every stream type
    the PMT announces. Our PMT declared the G711A track, but no audio packet ever
    followed, so the probe never finished: the producer was not created and the
    RTSP server did not answer a DESCRIBE until the doorbell sent real media,
    which took about 32 seconds with the bell asleep.
  • The opening header now carries one frame of G711A silence, written before
    dialling, which closes the probe immediately.

Verified

  • Read from go2rtc 1.9.15 sources (pkg/mpegts/producer.go probe waits for
    every stream type the PMT lists, including StreamTypePCMATapo 0x90).
  • A small program that calls mpegts.Open on the raw header: the old 564-byte
    header ends in ERROR: EOF, the new 752-byte header yields
    media=video codec=H264 and media=audio codec=PCMA.
  • Local go2rtc with the same version as the add-on now logs
    run pipe launch=2.318ms and answers DESCRIBE with both tracks in 3 to 11
    milliseconds, where before it hung inside the probe.
  • TestStreamHeaderCarriesBothTracks walks the TS packets of the header and
    requires PAT, PMT, video and audio. gofmt, go vet clean, suite green in
    7.9 s, coverage 64.0% against a CI floor of 62%.

Not verified

  • The add-on itself, which this release is about to be deployed to.
  • The picture: the doorbell still sends no keyframe (issue #6).