Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gnodev): disable wal #2230

Merged
merged 1 commit into from
May 29, 2024
Merged

fix(gnodev): disable wal #2230

merged 1 commit into from
May 29, 2024

Conversation

thehowl
Copy link
Member

@thehowl thehowl commented May 28, 2024

This will avoid creating the wal directory whenever gnodev is used.

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@thehowl thehowl self-assigned this May 28, 2024
@thehowl thehowl requested a review from gfanton as a code owner May 28, 2024 11:08
Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.94%. Comparing base (a21f12f) to head (ab63a32).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2230      +/-   ##
==========================================
- Coverage   49.94%   49.94%   -0.01%     
==========================================
  Files         576      576              
  Lines       77825    77826       +1     
==========================================
- Hits        38873    38872       -1     
- Misses      35827    35828       +1     
- Partials     3125     3126       +1     
Flag Coverage Δ
contribs/gnodev 24.24% <100.00%> (+0.06%) ⬆️
contribs/gnofaucet 14.46% <ø> (-0.86%) ⬇️
contribs/gnokeykc 0.00% <ø> (ø)
contribs/gnomd 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thehowl
Copy link
Member Author

thehowl commented May 29, 2024

cross-checked with guilhem, merging

@thehowl thehowl merged commit 088eeca into master May 29, 2024
50 checks passed
@thehowl thehowl deleted the dev/morgan/disable-wal branch May 29, 2024 08:32
omarsy pushed a commit to TERITORI/gno that referenced this pull request Jun 3, 2024
This will avoid creating the `wal` directory whenever `gnodev` is used.

<details><summary>Contributors' checklist...</summary>

- [ ] Added new tests, or not needed, or not feasible
- [ ] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [ ] Updated the official documentation or not needed
- [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [ ] Added references to related issues and PRs
- [ ] Provided any useful hints for running manual tests
- [ ] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants