Skip to content

Conversation

@D4ryl00
Copy link
Contributor

@D4ryl00 D4ryl00 commented Sep 19, 2024

This PR fixes an issue when you want to execute npm install in the expo folder, that fails with this error:

src/api/GnoNativeApi.ts:249:91 - error TS2561: Object literal may only specify known properties, but 'addresses' does not exist in type 'PartialMessage<UpdatePasswordRequest>'. Did you mean to write 'address'?

249     const response = await client.updatePassword(new UpdatePasswordRequest({ newPassword, addresses }));

It's because we need to update the gnonative API that implements the new addresses field in the request.

Signed-off-by: D4ryl00 <d4ryl00@gmail.com>
@D4ryl00 D4ryl00 requested a review from iuricmp September 19, 2024 09:46
@D4ryl00 D4ryl00 self-assigned this Sep 19, 2024
@D4ryl00 D4ryl00 requested a review from jefft0 September 23, 2024 10:06
Copy link
Contributor

@jefft0 jefft0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested npm install in the expo folder. Also did make npm.pack and tested it with dsocial.

@D4ryl00 D4ryl00 merged commit ecdd187 into gnolang:main Sep 23, 2024
@D4ryl00 D4ryl00 deleted the fix/code-lint branch September 23, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants