fix: typos & fixes: #460

Author: pchampio

accessibility.go

@@ -9,7 +9,7 @@ var defaultAccessibilityPlugin = &accessibilityPlugin{}
 
 func (p *accessibilityPlugin) InitPlugin(messenger plugin.BinaryMessenger) error {
 	channel := plugin.NewBasicMessageChannel(messenger, "flutter/accessibility", plugin.StandardMessageCodec{})
-	// Ignored: go-flutter dosn't support accessibility events
+	// Ignored: go-flutter doesn't support accessibility events
 	channel.HandleFunc(func(_ interface{}) (interface{}, error) { return nil, nil })
 	return nil
 }

go.mod

@@ -10,5 +10,4 @@ require (
 	github.com/pkg/errors v0.9.1
 	github.com/stretchr/testify v1.6.0
 	golang.org/x/text v0.3.2
-	gopkg.in/yaml.v2 v2.2.4 // indirect
 )

go.sum

@@ -23,8 +23,7 @@ github.com/smartystreets/goconvey v1.6.4 h1:fv0U8FUIMPNf1L9lnHLvLhgicrIVChEkdzIK
 github.com/smartystreets/goconvey v1.6.4/go.mod h1:syvi0/a8iFYH4r/RixwvyeAJjdLS9QV7WQ/tjFTllLA=
 github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME=
 github.com/stretchr/testify v1.4.0/go.mod h1:j7eGeouHqKxXV5pUuKE4zz7dFj8WfuZ+81PSLYec5m4=
-github.com/stretchr/testify v1.5.1 h1:nOGnQDM7FYENwehXlg/kFVnos3rEvtKTjRvOWSzb6H4=
-github.com/stretchr/testify v1.5.1/go.mod h1:5W2xD1RspED5o8YsWQXVCued0rvSQ+mT+I5cxcmMvtA=
+github.com/stretchr/testify v1.6.0 h1:jlIyCplCJFULU/01vCkhKuTyc3OorI3bJFuw6obfgho=
 github.com/stretchr/testify v1.6.0/go.mod h1:6Fq8oRcR53rry900zMqJjRRixrwX3KX962/h/Wwjteg=
 golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2/go.mod h1:djNgcEr1/C05ACkg1iLfiJU5Ep61QUkGW8qpdssI0+w=
 golang.org/x/net v0.0.0-20190311183353-d8887717615a/go.mod h1:t9HGtf8HONx5eT2rtn7q6eTqICYqUVnKs3thJo3Qplg=
@@ -38,6 +37,5 @@ gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405 h1:yhCVgyC4o1eVCa2tZl7eS0r+
 gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
 gopkg.in/yaml.v2 v2.2.2 h1:ZCJp+EgiOT7lHqUV2J862kp8Qj64Jo6az82+3Td9dZw=
 gopkg.in/yaml.v2 v2.2.2/go.mod h1:hI93XBmqTisBFMUTm0b8Fm+jr3Dg1NNxqwp+5A1VGuI=
-gopkg.in/yaml.v2 v2.2.4 h1:/eiJrUcujPVeJ3xlSWaiNi3uSVmDGBK1pDHUHAnao1I=
-gopkg.in/yaml.v2 v2.2.4/go.mod h1:hI93XBmqTisBFMUTm0b8Fm+jr3Dg1NNxqwp+5A1VGuI=
+gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c h1:dUUwHk2QECo/6vqA44rthZ8ie2QXMNeKRTHCNY2nXvo=
 gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=

internal/keyboard/keyboard.go

@@ -9,7 +9,7 @@ import (
 )
 
 // Event corresponds to a Flutter (dart) compatible RawKeyEventData keyevent data.
-// Multi-platform keycode translation is handled withing this package.
+// Multi-platform keycode translation is handled within this package.
 //
 // As input, go-flutter gets GLFW-keyevent who are only compatible with
 // RawKeyEventDataLinux. To fully support keyboard shortcut (like Command+C to

isolate.go

@@ -4,12 +4,12 @@ import "github.com/go-flutter-desktop/go-flutter/plugin"
 
 type isolatePlugin struct{}
 
-// hardcoded because there is no swappable renderer interface.
+// hard-coded because there is no swappable renderer interface.
 var defaultIsolatePlugin = &isolatePlugin{}
 
 func (p *isolatePlugin) InitPlugin(messenger plugin.BinaryMessenger) error {
 	channel := plugin.NewBasicMessageChannel(messenger, "flutter/isolate", plugin.StringCodec{})
-	// Ignored: go-flutter dosn't support isolate events
+	// Ignored: go-flutter doesn't support isolate events
 	channel.HandleFunc(func(_ interface{}) (interface{}, error) { return nil, nil })
 	return nil
 }

plugin/method-channel.go

@@ -146,7 +146,7 @@ func (m *MethodChannel) HandleFuncSync(methodName string, f func(arguments inter
 
 // ClearAllHandle clear all the handlers registered by
 // Handle\HandleFunc and HandleSync\HandleFuncSync.
-// ClearAllHandle dose not clear the handler registered by CatchAllHandle\CatchAllHandleFunc
+// ClearAllHandle doesn't not clear the handler registered by CatchAllHandle\CatchAllHandleFunc
 func (m *MethodChannel) ClearAllHandle() {
 	m.methodsLock.Lock()
 	m.methods = make(map[string]methodHandlerRegistration)

text-input.go

@@ -126,9 +126,15 @@ func (p *textinputPlugin) handleSetEditingState(arguments interface{}) (reply in
 		p.ed.SelectionExtent < 0 ||
 		p.ed.SelectionBase > utf16TextLen ||
 		p.ed.SelectionExtent > utf16TextLen {
-		// request a new EditingState
-		err := p.channel.InvokeMethod("TextInputClient.requestExistingInputState", nil)
-		return nil, err
+		// request a new EditingState if text is present in the TextInput
+		if p.ed.Text != "" {
+			err := p.channel.InvokeMethod("TextInputClient.requestExistingInputState", nil)
+			return nil, err
+		}
+		// otherwise, simply set sane default
+		p.ed.SelectionBase = 0
+		p.ed.SelectionExtent = 0
+		return nil, nil
 	}
 
 	return nil, nil