This repository has been archived by the owner on Apr 12, 2019. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some simplifications to prevent wheel re-invention:
hex.EncodeString(..)
instead of manually hex encoding012..ef
each call.copy(..)
instead of manually copying bytescopy
has architecture-specialized implementationsbytes.Equal(..)
instead of manually comparing bytesbytes.Equal
has architecture-specialized implementationsFor the record, converting an array to a slice (
arr[:]
) does not copy the array.