Merge branch 'master' into assets_dir

.editorconfig

@@ -12,6 +12,12 @@ insert_final_newline = true
 [*.{go,tmpl,html}]
 indent_style = tab
 
+[templates/custom/*.tmpl]
+insert_final_newline = false
+
+[templates/swagger/v1_json.tmpl]
+indent_style = space
+
 [Makefile]
 indent_style = tab
 

CHANGELOG.md

@@ -4,26 +4,17 @@ This changelog goes through all the changes that have been made in each release
 without substantial changes to our git log; to see the highlights of what has
 been added to each release, please refer to the [blog](https://blog.gitea.io).
 
-## [1.14.0-RC2](https://github.com/go-gitea/gitea/releases/tag/v1.14.0-rc2) - 2021-03-22
-
-* SECURITY
-  * Fix bug on avatar middleware (#15124) (#15125)
-  * Fix another clusterfuzz identified issue (#15096) (#15113)
-  * Update to goldmark 1.3.3 (#15059) (#15060)
-* BUGFIXES
-  * Fix the v176 migration (#15110) (#15111)
-  * Fix double 'push tag' action feed (#15078) (#15083)
-  * Remove possible resource leak (#15067) (#15082)
-  * Handle unauthorized user events gracefully (#15071) (#15074)
-
-## [1.14.0-RC1](https://github.com/go-gitea/gitea/releases/tag/v1.14.0-rc1) - 2021-03-19
+## [1.14.0](https://github.com/go-gitea/gitea/releases/tag/v1.14.0) - 2021-04-11
 
 * SECURITY
   * Respect approved email domain list for externally validated user registration (#15014)
   * Add reverse proxy configuration support for remote IP address detection (#14959)
   * Ensure validation occurs on clone addresses too (#14994)
   * Fix several render issues highlighted during fuzzing (#14986)
 * BREAKING
+  * Fix double 'push tag' action feed (#15078) (#15083)
+  * Remove possible resource leak (#15067) (#15082)
+  * Handle unauthorized user events gracefully (#15071) (#15074)
   * Restore Access.log following migration to Chi framework (Stops access logging of /api/internal routes) (#14475)
   * Migrate from Macaron to Chi framework (#14293)
   * Deprecate building for mips (#14174)
@@ -54,6 +45,7 @@ been added to each release, please refer to the [blog](https://blog.gitea.io).
   * Dump github/gitlab/gitea repository data to a local directory and restore to gitea (#12244)
   * Create Rootless Docker image (#10154)
 * API
+  * Speedup issue search (#15179) (#15192)
   * Get pull, return head branch sha, even if deleted (#14931)
   * Export LFS & TimeTracking function status (#14753)
   * Show Gitea version in swagger (#14654)
@@ -78,6 +70,20 @@ been added to each release, please refer to the [blog](https://blog.gitea.io).
   * Add more filters to issues search (#13514)
   * Add review request api (#11355)
 * BUGFIXES
+  * Fix delete nonexist oauth application 500 and prevent deadlock (#15384) (#15396)
+  * Always set the merge base used to merge the commit (#15352) (#15385)
+  * Upgrade to bluemonday 1.0.7 (#15379) (#15380)
+  * Turn RepoRef and RepoAssignment back into func(*Context) (#15372) (#15377)
+  * Move FCGI req.URL.Path fix-up to the FCGI listener (#15292) (#15361)
+  * Show diff on rename with diff changes (#15338) (#15339)
+  * Fix handling of logout event (#15323) (#15337)
+  * Fix CanCreateRepo check (#15311) (#15321)
+  * Fix xorm log stack level (#15285) (#15316)
+  * Fix bug in Wrap (#15302) (#15309)
+  * Drop the event source if we are unauthorized (#15275) (#15280)
+  * Backport Fix graph pagination (#15225)  (#15249)
+  * Prevent NPE in CommentMustAsDiff if no hunk header (#15199) (#15200)
+  * should run RetrieveRepoMetas() for empty pr (#15187) (#15190)
   * Move setting to enable closing issue via commit in non default branch to repo settings (#14965)
   * Show correct issues for team dashboard (#14952)
   * Ensure that new pull request button works on forked forks owned by owner of the root and reduce ambiguity (#14932)
@@ -134,6 +140,9 @@ been added to each release, please refer to the [blog](https://blog.gitea.io).
   * Use GO variable in go-check target (#13146) (#13147)
 * ENHANCEMENTS
   * UI style improvements
+  * Dropzone styling improvements (#15291) (#15374)
+  * Add size to Save function (#15264) (#15270)
+  * Monaco improvements (#15333) (#15345)
   * Support .mailmap in code activity stats (#15009)
   * Sort release attachments by name (#15008)  
   * Add ui.explore settings to control view of explore pages (#14094)

Makefile

@@ -325,6 +325,7 @@ lint: lint-frontend lint-backend
 lint-frontend: node_modules
 	npx eslint --color --max-warnings=0 web_src/js build templates *.config.js
 	npx stylelint --color --max-warnings=0 web_src/less
+	npx editorconfig-checker templates
 
 .PHONY: lint-backend
 lint-backend: golangci-lint revive vet

docs/config.yaml

@@ -18,7 +18,7 @@ params:
   description: Git with a cup of tea
   author: The Gitea Authors
   website: https://docs.gitea.io
-  version: 1.13.7
+  version: 1.14.0
   minGoVersion: 1.14
   goVersion: 1.16
   minNodeVersion: 12.17

modules/git/blob_test.go

@@ -7,39 +7,23 @@ package git
 
 import (
 	"io/ioutil"
+	"path/filepath"
 	"testing"
 
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 )
 
 func TestBlob_Data(t *testing.T) {
-	output := `Copyright (c) 2016 The Gitea Authors
-Copyright (c) 2015 The Gogs Authors
-
-Permission is hereby granted, free of charge, to any person obtaining a copy
-of this software and associated documentation files (the "Software"), to deal
-in the Software without restriction, including without limitation the rights
-to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-copies of the Software, and to permit persons to whom the Software is
-furnished to do so, subject to the following conditions:
-
-The above copyright notice and this permission notice shall be included in
-all copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
-THE SOFTWARE.
-`
-	repo, err := OpenRepository("../../.git")
-	assert.NoError(t, err)
+	output := "file2\n"
+	bareRepo1Path := filepath.Join(testReposDir, "repo1_bare")
+	repo, err := OpenRepository(bareRepo1Path)
+	if !assert.NoError(t, err) {
+		t.Fatal()
+	}
 	defer repo.Close()
 
-	testBlob, err := repo.GetBlob("a8d4b49dd073a4a38a7e58385eeff7cc52568697")
+	testBlob, err := repo.GetBlob("6c493ff740f9380390d5c9ddef4af18697ac9375")
 	assert.NoError(t, err)
 
 	r, err := testBlob.DataAsync()
@@ -53,13 +37,14 @@ THE SOFTWARE.
 }
 
 func Benchmark_Blob_Data(b *testing.B) {
-	repo, err := OpenRepository("../../.git")
+	bareRepo1Path := filepath.Join(testReposDir, "repo1_bare")
+	repo, err := OpenRepository(bareRepo1Path)
 	if err != nil {
 		b.Fatal(err)
 	}
 	defer repo.Close()
 
-	testBlob, err := repo.GetBlob("a8d4b49dd073a4a38a7e58385eeff7cc52568697")
+	testBlob, err := repo.GetBlob("6c493ff740f9380390d5c9ddef4af18697ac9375")
 	if err != nil {
 		b.Fatal(err)
 	}

options/locale/locale_cs-CZ.ini

@@ -1096,7 +1096,6 @@ issues.context.edit=Upravit
 issues.context.delete=Smazat
 issues.no_content=Není zde žádný obsah.
 issues.close_issue=Zavřít
-issues.pull_merged_at=`sloučil(a) revizi <a href="%[1]s">%[2]s</a> do <b>%[3]s</b> %[4]s`
 issues.close_comment_issue=Okomentovat a zavřít
 issues.reopen_issue=Znovuotevřít
 issues.reopen_comment_issue=Okomentovat a znovuotevřít
@@ -1187,7 +1186,6 @@ issues.error_modifying_due_date=Změna termínu dokončení selhala.
 issues.error_removing_due_date=Odstranění termínu dokončení selhalo.
 issues.push_commit_1=přidal(a) %d revizi %s
 issues.push_commits_n=přidal(a) %d revize %s
-issues.force_push_codes=`vynucené nahrání %[1]s z <a href="%[3]s">%[2]s</a> do <a href="%[5]s">%[4]s</a> %[6]s`
 issues.due_date_form=rrrr-mm-dd
 issues.due_date_form_add=Přidat termín dokončení
 issues.due_date_form_edit=Upravit

options/locale/locale_de-DE.ini

@@ -1112,8 +1112,6 @@ issues.context.edit=Bearbeiten
 issues.context.delete=Löschen
 issues.no_content=Hier gibt es bis jetzt noch keinen Inhalt.
 issues.close_issue=Schließen
-issues.pull_merged_at=`hat den Commit <a href="%[1]s">%[2]s</a> in <b>%[3]s</b> %[4]s gemergt`
-issues.manually_pull_merged_at=`hat %[4]s den Commit <a href="%[1]s">%[2]s</a> manuell in <b>%[3]s</b> gemergt`
 issues.close_comment_issue=Kommentieren und schließen
 issues.reopen_issue=Wieder öffnen
 issues.reopen_comment_issue=Kommentieren und wieder öffnen
@@ -1207,7 +1205,6 @@ issues.error_modifying_due_date=Fehler beim Ändern des Fälligkeitsdatums.
 issues.error_removing_due_date=Fehler beim Entfernen des Fälligkeitsdatums.
 issues.push_commit_1=hat %d Commit %s hinzugefügt
 issues.push_commits_n=hat %d Commits %s hinzugefügt
-issues.force_push_codes=`force-pushte %[1]s von <a href="%[3]s">%[2]s</a> auf <a href="%[5]s">%[4]s</a> %[6]s`
 issues.due_date_form=JJJJ-MM-TT
 issues.due_date_form_add=Fälligkeitsdatum hinzufügen
 issues.due_date_form_edit=Bearbeiten

options/locale/locale_es-ES.ini

@@ -1112,8 +1112,6 @@ issues.context.edit=Editar
 issues.context.delete=Eliminar
 issues.no_content=Aún no existe contenido.
 issues.close_issue=Cerrar
-issues.pull_merged_at=`fusionado commit <a href="%[1]s">%[2]s</a> en <b>%[3]s</b> %[4]s`
-issues.manually_pull_merged_at=`fusionado manualmente commit <a href="%[1]s">%[2]s</a> en <b>%[3]s</b> %[4]s`
 issues.close_comment_issue=Comentar y cerrar
 issues.reopen_issue=Reabrir
 issues.reopen_comment_issue=Comentar y reabrir
@@ -1207,7 +1205,6 @@ issues.error_modifying_due_date=Fallo al modificar la fecha de vencimiento.
 issues.error_removing_due_date=Fallo al eliminar la fecha de vencimiento.
 issues.push_commit_1=añadido %d commit %s
 issues.push_commits_n=añadido %d commits %s
-issues.force_push_codes=`hizo push forzado %[1]s de <a href="%[3]s">%[2]s</a> a <a href="%[5]s">%[4]s</a> %[6]s`
 issues.due_date_form=aaaa-mm-dd
 issues.due_date_form_add=Añadir fecha de vencimiento
 issues.due_date_form_edit=Editar

options/locale/locale_fa-IR.ini

@@ -960,7 +960,6 @@ issues.context.edit=ویرایش
 issues.context.delete=حذف
 issues.no_content=هنوز محتوایی ایجاد نشده.
 issues.close_issue=ببند
-issues.pull_merged_at=`انجام ادغام تغییرات <a href="%[1]s">%[2]s</a> داخل <b>%[3]s</b> %[4]s`
 issues.close_comment_issue=ثبت دیدگاه و بستن
 issues.reopen_issue=بازگشایی
 issues.reopen_comment_issue=ثبت دیدگاه و بازگشایی
@@ -1046,7 +1045,6 @@ issues.error_modifying_due_date=تغییر موعد مقرر با شکست مو
 issues.error_removing_due_date=حذف موعد مقرر با شکست مواجه شد.
 issues.push_commit_1=%d اعمال تغییر اضافه شده است %s
 issues.push_commits_n=%d اعمال تغییرات اضافه شده است %s
-issues.force_push_codes=`ارسال به سرور اجباری %[1] از  <a href="%[3]s">%[2]s</a> به<a href="%[5]s">%[4]s</a> %[6]s`
 issues.due_date_form=yyyy-mm-dd
 issues.due_date_form_add=افزودن موعد مقرر
 issues.due_date_form_edit=ویرایش

options/locale/locale_fr-FR.ini

@@ -1039,7 +1039,6 @@ issues.context.edit=Éditer
 issues.context.delete=Supprimer
 issues.no_content=Il n'existe pas encore de contenu.
 issues.close_issue=Fermer
-issues.pull_merged_at=`commit de fusion <a href="%[1]s">%[2]s</a> dans <b>%[3]s</b> %[4]s`
 issues.close_comment_issue=Commenter et Fermer
 issues.reopen_issue=Réouvrir
 issues.reopen_comment_issue=Commenter et Réouvrir

options/locale/locale_it-IT.ini

@@ -1053,7 +1053,6 @@ issues.context.edit=Modifica
 issues.context.delete=Elimina
 issues.no_content=Non ci sono ancora contenuti.
 issues.close_issue=Chiudi
-issues.pull_merged_at=`merged commit <a href="%[1]s">%[2]s</a> in <b>%[3]s</b> %[4]s`
 issues.close_comment_issue=Commenta e Chiudi
 issues.reopen_issue=Riapri
 issues.reopen_comment_issue=Commenta e Riapri
@@ -1140,7 +1139,6 @@ issues.error_modifying_due_date=Impossibile modificare la data di scadenza.
 issues.error_removing_due_date=Impossibile rimuovere la data di scadenza.
 issues.push_commit_1=aggiunto %d commit %s
 issues.push_commits_n=aggiunto %d commit %s
-issues.force_push_codes=`force-pushed %[1]s da <a href="%[3]s">%[2]s</a> a <a href="%[5]s">%[4]s</a> %[6]s`
 issues.due_date_form=yyyy-mm-dd
 issues.due_date_form_add=Aggiungi data di scadenza
 issues.due_date_form_edit=Modifica

options/locale/locale_ja-JP.ini

@@ -1112,8 +1112,6 @@ issues.context.edit=編集
 issues.context.delete=削除
 issues.no_content=まだ内容がありません
 issues.close_issue=クローズする
-issues.pull_merged_at=`がコミット <a href="%[1]s">%[2]s</a> を <b>%[3]s</b> にマージ %[4]s`
-issues.manually_pull_merged_at=`がコミット <a href="%[1]s">%[2]s</a> を <b>%[3]s</b> に手動マージ %[4]s`
 issues.close_comment_issue=コメントしてクローズ
 issues.reopen_issue=再オープンする
 issues.reopen_comment_issue=コメントして再オープン
@@ -1207,7 +1205,6 @@ issues.error_modifying_due_date=期日を変更できませんでした。
 issues.error_removing_due_date=期日を削除できませんでした。
 issues.push_commit_1=が %d コミット追加 %s
 issues.push_commits_n=が %d コミット追加 %s
-issues.force_push_codes=`が %[1]s を <a href="%[3]s">%[2]s</a> から <a href="%[5]s">%[4]s</a> に強制プッシュ %[6]s`
 issues.due_date_form=yyyy-mm-dd
 issues.due_date_form_add=期日の追加
 issues.due_date_form_edit=変更

options/locale/locale_lv-LV.ini

@@ -1105,8 +1105,6 @@ issues.context.edit=Labot
 issues.context.delete=Dzēst
 issues.no_content=Vēl nav satura.
 issues.close_issue=Aizvērt
-issues.pull_merged_at=`sapludināja revīziju <a href="%[1]s">%[2]s</a> atzarā <b>%[3]s</b> %[4]s`
-issues.manually_pull_merged_at=`manuāli sapludināja revīziju <a href="%[1]s">%[2]s</a> atzarā <b>%[3]s</b> %[4]s`
 issues.close_comment_issue=Komentēt un aizvērt
 issues.reopen_issue=Atvērt atkārtoti
 issues.reopen_comment_issue=Komentēt un atvērt atkārtoti
@@ -1200,7 +1198,6 @@ issues.error_modifying_due_date=Neizdevās izmainīt izpildes termiņu.
 issues.error_removing_due_date=Neizdevās noņemt izpildes termiņu.
 issues.push_commit_1=iesūtīja %d revīziju %s
 issues.push_commits_n=iesūtīja %d revīzijas %s
-issues.force_push_codes=`veica piespiedu izmaiņu nosūtīšanu atzaram %[1]s no <a href="%[3]s">%[2]s</a> uz <a href="%[5]s">%[4]s</a> %[6]s`
 issues.due_date_form=yyyy-mm-dd
 issues.due_date_form_add=Pievienot izpildes termiņu
 issues.due_date_form_edit=Labot

options/locale/locale_nl-NL.ini

@@ -1043,7 +1043,6 @@ issues.context.edit=Bewerken
 issues.context.delete=Verwijder
 issues.no_content=Er is nog geen inhoud.
 issues.close_issue=Sluit
-issues.pull_merged_at=`heeft commit <a href="%[1]s">%[2]s</a> samengevoegd in <b>%[3]s</b> %[4]s`
 issues.close_comment_issue=Reageer en sluit
 issues.reopen_issue=Heropen
 issues.reopen_comment_issue=Heropen en geef commentaar
@@ -1130,7 +1129,6 @@ issues.error_modifying_due_date=Deadline aanpassen mislukt.
 issues.error_removing_due_date=Deadline verwijderen mislukt.
 issues.push_commit_1=toegevoegd %d commit %s
 issues.push_commits_n=toegevoegd %d commits %s
-issues.force_push_codes=`geforceerd-pushed %[1]s van <a href="%[3]s">%[2]s</a> naar <a href="%[5]s">%[4]s</a> %[6]s`
 issues.due_date_form=jjjj-mm-dd
 issues.due_date_form_add=Vervaldatum toevoegen
 issues.due_date_form_edit=Bewerk

options/locale/locale_pl-PL.ini

@@ -982,7 +982,6 @@ issues.context.edit=Edytuj
 issues.context.delete=Usuń
 issues.no_content=Nie ma jeszcze treści.
 issues.close_issue=Zamknij
-issues.pull_merged_at=`scalił(-a) commit <a href="%[1]s">%[2]s</a> do <b>%[3]s</b> %[4]s`
 issues.close_comment_issue=Skomentuj i zamknij
 issues.reopen_issue=Otwórz ponownie
 issues.reopen_comment_issue=Skomentuj i otwórz ponownie
@@ -1068,7 +1067,6 @@ issues.error_modifying_due_date=Nie udało się zmodyfikować terminu realizacji
 issues.error_removing_due_date=Nie udało się usunąć terminu realizacji.
 issues.push_commit_1=dodał(-a) %d commit %s
 issues.push_commits_n=dodał(-a) %d commity(-ów) %s
-issues.force_push_codes=`przymusowo wypchnął %[1]s z <a href="%[3]s">%[2]s</a> do <a href="%[5]s">%[4]s</a> %[6]s`
 issues.due_date_form=yyyy-mm-dd
 issues.due_date_form_add=Dodaj termin realizacji
 issues.due_date_form_edit=Edytuj

options/locale/locale_pt-PT.ini

@@ -1108,8 +1108,6 @@ issues.context.edit=Editar
 issues.context.delete=Eliminar
 issues.no_content=Ainda não há conteúdo.
 issues.close_issue=Fechar
-issues.pull_merged_at=`cometimento <a href="%[1]s">%[2]s</a> integrado em <b>%[3]s</b> %[4]s`
-issues.manually_pull_merged_at=`integrou o cometimento <a href="%[1]s"> [2] </a> em <b> [3] </b> [4] manualmente`
 issues.close_comment_issue=Comentar e fechar
 issues.reopen_issue=Reabrir
 issues.reopen_comment_issue=Comentar e reabrir
@@ -1203,7 +1201,6 @@ issues.error_modifying_due_date=Falha ao modificar a data limite.
 issues.error_removing_due_date=Falha ao remover a data limite.
 issues.push_commit_1=adicionou %d cometimento %s
 issues.push_commits_n=adicionou %d cometimentos %s
-issues.force_push_codes=`forçou o envio de %[1]s de <a href="%[3]s">%[2]s</a> para <a href="%[5]s">%[4]s</a> %[6]s`
 issues.due_date_form=yyyy-mm-dd
 issues.due_date_form_add=Adicionar data limite
 issues.due_date_form_edit=Editar

options/locale/locale_ru-RU.ini

@@ -1107,8 +1107,6 @@ issues.context.edit=Редактировать
 issues.context.delete=Удалить
 issues.no_content=Пока нет содержимого.
 issues.close_issue=Закрыть
-issues.pull_merged_at=`Объединил коммит <a href="%[1]s">%[2]s</a> на <b>%[3]s</b> %[4]s`
-issues.manually_pull_merged_at=`Объединил коммит <a href="%[1]s">%[2]s</a> с <b>%[3]s</b> %[4]s вручную`
 issues.close_comment_issue=Прокомментировать и закрыть
 issues.reopen_issue=Открыть снова
 issues.reopen_comment_issue=Прокомментировать и открыть снова
@@ -1202,7 +1200,6 @@ issues.error_modifying_due_date=Не удалось изменить срок в
 issues.error_removing_due_date=Не удалось убрать срок выполнения.
 issues.push_commit_1=добавил(а) %d коммит %s
 issues.push_commits_n=добавил(а) %d коммитов %s
-issues.force_push_codes=`Принудительный push %[1]s ветки из <a href="%[3]s">%[2]s</a> to <a href="%[5]s">%[4]s</a>. %[6]s`
 issues.due_date_form=гггг-мм-дд
 issues.due_date_form_add=Добавить срок выполнения
 issues.due_date_form_edit=Редактировать

options/locale/locale_sv-SE.ini

@@ -1004,7 +1004,6 @@ issues.context.edit=Redigera
 issues.context.delete=Ta bort
 issues.no_content=Det finns inget innehåll än.
 issues.close_issue=Stäng
-issues.pull_merged_at=`sammanfogade commit <a href="%[1]s">%[2]s</a> in i <b>%[3]s</b> %[4]s`
 issues.close_comment_issue=Kommentera och stäng
 issues.reopen_issue=Återöppna
 issues.reopen_comment_issue=Kommentera och återöppna

options/locale/locale_tr-TR.ini

@@ -1107,8 +1107,6 @@ issues.context.edit=Düzenle
 issues.context.delete=Sil
 issues.no_content=Henüz bir içerik yok.
 issues.close_issue=Kapat
-issues.pull_merged_at=`<a href="%[1]s">%[2]s</a> işlemesini <b>%[3]s</b> ile %[4]s birleştirdi`
-issues.manually_pull_merged_at=`<a href="%[1]s">%[2]s</a> işlemesini <b>%[3]s</b> %[4]s elle birleştirdi`
 issues.close_comment_issue=Yorum Yap ve Kapat
 issues.reopen_issue=Yeniden aç
 issues.reopen_comment_issue=Yorum Yap ve Yeniden Aç
@@ -1202,7 +1200,6 @@ issues.error_modifying_due_date=Bitiş tarihi değiştirilemedi.
 issues.error_removing_due_date=Bitiş tarihi silinemedi.
 issues.push_commit_1=%d işlemeyi %s ekledi
 issues.push_commits_n=%d işlemeyi %s ekledi
-issues.force_push_codes=`%[1]s <a href="%[3]s">%[2]s</a> konumundan <a href="%[5]s">%[4]s</a> %[6]s konumuna zorla güncellendi`
 issues.due_date_form=yyyy-aa-gg
 issues.due_date_form_add=Bitiş tarihi ekle
 issues.due_date_form_edit=Düzenle