Pull request #947 / #1753 (still) breaks HTTPS clone/push/pull to/from "master" when logged in as Admin

[wyattoday]

• Gitea version (or commit ref): 281a038 or fix admin lost permission caused by #947 #1753
• Git version: 2.13
• Operating system: Ubuntu 16.04
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No
  • Not relevant
• Log gist:

Description

This is a followup to the issue that was closed (but not fixed): #1751

The proposed fix still breaks things (or leaves things broken). For example, as an admin user, when cloning an existing repository, I get an empty directory:

git.exe clone --progress -v "https://example.com/git/repository_name.git" "C:\Users\USERNAME\Documents\repository_name"

Cloning into 'C:\Users\USERNAME\Documents\repository_name'...
warning: You appear to have cloned an empty repository.

Success (641 ms @ 5/19/2017 8:08:51 AM)

Other things are broken as well (pulling still broken, haven't tried pushing yet).

Rolling back to before fd6034a fixes things for me.

Screenshots

If this issue involves the Web Interface, please include a screenshot

[sapk]

cc @lunny maybe we should add integration test to validate action as an admin in a other PR.

[lunny]

@sapk you are right! I remember I have sent a PR to add clone test, but not merged?

[sapk]

Thx I will have a look at #1682

[wyattoday]

This bug was fixed in a newer build. No sure which one, but I'm closing this issue.