Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commits picker in PR change files view #19263

Closed
luwol03 opened this issue Mar 29, 2022 · 1 comment · Fixed by #25528
Closed

Commits picker in PR change files view #19263

luwol03 opened this issue Mar 29, 2022 · 1 comment · Fixed by #25528
Labels
type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first.
Milestone
1.21.0

Comments

@luwol03
Copy link

luwol03 commented Mar 29, 2022

Feature Description

I think it would be great, if gitea also has a commits picker while browsing through the changed files of a pull request like github have it. When #19007 is implemented, this could also cover since your last review.

Screenshots

image
@luwol03 luwol03 added type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first. labels Mar 29, 2022
@sebastian-sauer
Copy link
Contributor

#25528 adds a commit picker to files tab in PRs.

@sebastian-sauer sebastian-sauer mentioned this issue Jul 6, 2023
Merged
delvh added a commit that referenced this issue Jul 28, 2023
@sebastian-sauer @silverwind
@KN4CK3R @wxiaoguang @delvh
Add commits dropdown in PR files view and allow commit by commit revi…
5553206 
…ew (#25528)

This PR adds a new dropdown to select a commit or a commit range
(shift-click like github) of a Pull Request.
After selection of a commit only the changes of this commit will be shown.
When selecting a range of commits the diff of this range is shown.

This allows to review a PR commit by commit or by viewing only commit ranges.
The "Show changes since your last review" mechanism github uses is implemented, too.
When reviewing a single commit or a commit range the "Viewed" functionality is disabled.

## Screenshots

### The commit dropdown

![image](https://github.com/go-gitea/gitea/assets/51889757/0db3ae62-1272-436c-be64-4730c5d611e3)

### Selecting a commit range

![image](https://github.com/go-gitea/gitea/assets/51889757/ad81eedb-8437-42b0-8073-2d940c25fe8f)

### Show changes of a single commit only

![image](https://github.com/go-gitea/gitea/assets/51889757/6b1a113b-73ef-4ecc-adf6-bc2340bb8f97)

### Show changes of a commit range

![image](https://github.com/go-gitea/gitea/assets/51889757/6401b358-cd66-4c09-8baa-6cf6177f23a7)


Fixes #20989
Fixes #19263

---------

Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: delvh <dev.lh@web.de>
@lunny lunny added this to the 1.21.0 milestone Jul 29, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
1.21.0
Development

Successfully merging a pull request may close this issue.

Add commits dropdown in PR files view and allow commit by commit review sebastian-sauer/gitea
3 participants
@lunny @sebastian-sauer @luwol03