Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sending empty notifications #19589

Merged
merged 1 commit into from
May 3, 2022
Merged

Fix sending empty notifications #19589

merged 1 commit into from
May 3, 2022

Conversation

Gusted
Copy link
Contributor

@Gusted Gusted commented May 3, 2022

  • Don't send empty notifications on read notifications API.

Fix sending empty notifications
897ffd7 
- Don't send empty notifications on read notifications API.
@Gusted Gusted added this to the 1.17.0 milestone May 3, 2022
@Gusted Gusted added type/bug modifies/api This PR adds API routes or modifies them labels May 3, 2022
Gusted pushed a commit to Gusted/gitea that referenced this pull request May 3, 2022
Fix sending empty notifications (go-gitea#19589)
d75c348 
- Backport go-gitea#19589
  - Don't send empty notifications on read notifications API.
@Gusted Gusted mentioned this pull request May 3, 2022
Merged
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@438646e). Click here to learn what that means.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main   #19589   +/-   ##
=======================================
  Coverage        ?   47.40%           
=======================================
  Files           ?      952           
  Lines           ?   132660           
  Branches        ?        0           
=======================================
  Hits            ?    62891           
  Misses          ?    62192           
  Partials        ?     7577
Impacted Files Coverage Δ
routers/api/v1/notify/repo.go 86.01% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 438646e...897ffd7. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 3, 2022
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 3, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 3, 2022
@jolheiser jolheiser merged commit c8ec226 into go-gitea:main May 3, 2022
jolheiser pushed a commit that referenced this pull request May 3, 2022
Fix sending empty notifications (#19589) (#19590)
82f24be 
- Backport #19589
  - Don't send empty notifications on read notifications API.
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 3, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
94f1981 
* giteaofficial/main:
  Fix some slice problems (incorrect slice length) (go-gitea#19592)
  Fix sending empty notifications (go-gitea#19589)
  Handle the error of a missing blob object fix go-gitea#19530 (go-gitea#19552)
  Remove legacy `+build:` constraint (go-gitea#19582)
  Federation: return useful statistic information for nodeinfo (go-gitea#19561)
  Upgrade required git version to 2.0 (go-gitea#19577)
  add smtp password to install page (go-gitea#17564)
  ignore DNS error when doing migration allow/block check (go-gitea#19566)
  [skip ci] Updated translations via Crowdin
  Dont overwrite err with nil & rename PullCheckingFuncs to reflect there usage (go-gitea#19572)
  Improve UI on mobile (go-gitea#19546)
  Add API to check if team has repo access (go-gitea#19540)
@Gusted Gusted deleted the no-empty-read-not branch May 3, 2022 14:16
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
@AbdulrhmnGhanem
Fix sending empty notifications (go-gitea#19589)
0b8e495 
- Don't send empty notifications on read notifications API.
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@a1012112796 a1012112796 a1012112796 approved these changes

@jolheiser jolheiser jolheiser approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/bug
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Gusted @codecov-commenter @a1012112796 @jolheiser @GiteaBot