Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Caught a flaky test: #23608

Closed
lunny opened this issue Mar 21, 2023 · 0 comments · Fixed by #23753
Closed

Caught a flaky test: #23608

lunny opened this issue Mar 21, 2023 · 0 comments · Fixed by #23753
Labels
type/testing

Comments

@lunny
Copy link
Member

lunny commented Mar 21, 2023

Caught a flaky test:

https://drone.gitea.io/go-gitea/gitea/70256/2/14

--- FAIL: TestPersistableChannelUniqueQueue (0.62s)

    unique_queue_disk_channel_test.go:227: TestPersistableChannelUniqueQueue executedInitiallyA=57, executedInitiallyB=75, executedToEmptyA=44, executedToEmptyB=26

    --- FAIL: TestPersistableChannelUniqueQueue/Empty_Queue:_QueueA#01 (0.17s)

        unique_queue_disk_channel_test.go:210: 

            	Error Trace:	/drone/src/modules/queue/unique_queue_disk_channel_test.go:210

            	Error:      	Not equal: 

            	            	expected: 101

            	            	actual  : 100

            	Test:       	TestPersistableChannelUniqueQueue/Empty_Queue:_QueueA#01

        unique_queue_disk_channel_test.go:211: 

            	Error Trace:	/drone/src/modules/queue/unique_queue_disk_channel_test.go:211

            	Error:      	Not equal: 

            	            	expected: 0

            	            	actual  : 1

            	Test:       	TestPersistableChannelUniqueQueue/Empty_Queue:_QueueA#01

    unique_queue_disk_channel_test.go:256: TestPersistableChannelUniqueQueue executedInitiallyA=21, executedInitiallyB=100, executedToEmptyA=79, executedToEmptyB=1

FAIL

Originally posted by @wxiaoguang in #23154 (comment)
@wxiaoguang wxiaoguang mentioned this issue Apr 7, 2023
Closed
@silverwind silverwind mentioned this issue Apr 29, 2023
Merged
silverwind added a commit that referenced this issue Apr 29, 2023
@silverwind
Skip known flaky queue tests on CI environment (#24419)
fc62992 
Random CI failures are annoying. It's better to just skip the affected
tests so maintainers can use their valuable time for more productive
topics.

Related: #23608
Related: #23977
Related: #18703
@silverwind silverwind mentioned this issue May 3, 2023
Merged
silverwind pushed a commit that referenced this issue May 4, 2023
@zeripath @KN4CK3R
Fix intermittent CI failure in EmptyQueue (#23753)
ad8631c 
The ordering of the final token causing a close of the queue in this
test may be out of sync due to concurrency. Instead just use ensure that
the queue is closed when everything expected is done.

Fixes: #23608
Fixes: #23977

---------

Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix intermittent CI failure in EmptyQueue zeripath/gitea
2 participants
@lunny @silverwind