Skip to content

Different review status symbol for stale approvals (in Reviewers area of PR) #26306

@sebastian-sauer

Description

@sebastian-sauer

Feature Description

Given the following config:
Branch Protection activated, at least 1 approval and Dismiss stale reviews activated.

When I create a PR and Bob reviews the PR his name will get a green checkmark in Reviewers area. (as expected)
I'll now push a change to this PR and Bobs review is dismissed.
The reviewers section now shows me the "hourglass" icon (changes after review) AND it shows me the green checkmark.

At least for me it feels like the green checkmark signals that everything is "good to go". But actually Bob needs to reapprove the changes.

Suggestion: use an orange checkmark (signalling there was an approved review but it's not based on latest PR sha)

Screenshots

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    type/proposalThe new feature has not been accepted yet but needs to be discussed first.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions