Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple assignees #3705

Merged
merged 119 commits into from May 9, 2018
Merged

Multiple assignees #3705

merged 119 commits into from May 9, 2018

Conversation

kolaente
Copy link
Member

@kolaente kolaente commented Mar 22, 2018 •
edited

Blocked by go-gitea/go-sdk#99

This implements multiple assignees as of #1884. You can add and remove multiple assignees via the ui when creating issues or pull requests on the sidebar to the right as you do with labels.

I modified the api to reflect Github's API behavior while being backwards compatible.

Todo

  • Unit tests for new functions
  • Update go-sdk once it's merged

@kolaente
Issue assignees are now loaded of a seperate table when displayed in …
1bd777b 
…the UI
@kolaente
Multiple assignees work so far, but current state is alpha
3c0b4e1
@kolaente
Various cleanups
3d69908
@kolaente
Made removing all assignees working again
8720925
@kolaente
Don't send the action attribute, its not used
edad903
@kolaente
Made adding assignes via gui almost work
269f426
@kolaente
fmt
6583569
@kolaente
Made adding assignees work when creating an issue
a0bf332
@kolaente
cleanup
cf6d9d3
@kolaente
When viewing issues or prs via the api, assignees are now shown corre…
df4dc8d 
…cctly
@kolaente
Added assignee things when adding/updating an issue/pr via the api
2c88374
@kolaente
Merge remote-tracking branch 'upstream/master' into multiple-assignees
8d382ac
@kolaente
Issue assignees now recive notifications
fa0f918
@kolaente
Cleanup
8a57bba
@kolaente
Added checking for assignees to timetracking
3f525e0
@kolaente
Small fixes and improvements
0dc735e
@kolaente
More small fixes and improvements
f302943
@kolaente
Filtering by issue assignee works again
cb9d4d5
@kolaente
Stats working again when filtering by assignee
4cdfea5
@kolaente
Added old assigneeID when creating an issue/pr
be8d754 
+ re-added setting to add assignees when creating a pr
@kolaente
Merge branch 'master' of https://github.com/go-gitea/gitea into multi…
fbe62cd 
…ple-assignees

# Conflicts:
#	models/migrations/migrations.go
#	models/migrations/v58.go
@kolaente
fmt
2ae1bae
@kolaente
Fixed assignes showing up two times on issue page
5cddeb5 
+ smaller fixes and improvmentsk
@kolaente
fmt + lint
e8a019a
@kolaente
Merge branch 'master' of https://github.com/go-gitea/gitea into multi…
d2e780e 
…ple-assignees
@kolaente
Merge remote-tracking branch 'upstream/master' into multiple-assignees
84540bb
@kolaente
Merge branch 'master' of https://github.com/go-gitea/gitea into multi…
1d9fbc5 
…ple-assignees
@kolaente
Small design settings
ed600df
@kolaente
Made adding assignees when creating issues with the api work again
660be02
@kolaente
Added editing assignees via api working again
55e8e2c
@lafriks
Copy link
Member

lafriks commented May 5, 2018

@koalente no, if you check to assign user to issue and then when you click outside dropdown it will redirect to issue list

@kolaente
Copy link
Member Author

kolaente commented May 5, 2018 •
edited

@lafriks weired, I cannot reproduce that on Firefox 61 nor chromium 66.0.3359.139. This seems to be a client problem,which browser are you using?

I'll set up a testintance later this day.

@kolaente
Copy link
Member Author

kolaente commented May 5, 2018

Set up the test instance: https://gitea-dev.kolaente.de/

@lafriks Can you reproduce the issue over there?

@jonasfranz
Copy link
Member

jonasfranz commented May 6, 2018 •
edited

@lafriks I could not reproduce that issue at my localhost instance using Firefox 59.0.2, Epiphany 3.18.11, or Chrome 66.0.3359.139.

@lafriks
Copy link
Member

lafriks commented May 8, 2018

@kolaente yes now it is fixed, when I tested it was not. Now it works as one expect. There is still small cavet that if you add assignees and than clear them without saving that new issue it will still try to redirect and asks if I want to navigate away from that page and have unsaved data.

lafriks
lafriks approved these changes May 8, 2018
View reviewed changes
Copy link
Member

@lafriks lafriks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That small remaining issue should probably needs to be fixed but probably it's not a blocking issue

@kolaente
Copy link
Member Author

kolaente commented May 9, 2018

@lafriks great, I fixed that issue as well now.

@lafriks
Copy link
Member

lafriks commented May 9, 2018

@kolaente can't test right now but does this work also from issue list for batch issue assigning?

@lafriks
Copy link
Member

lafriks commented May 9, 2018

or at least does not break it's functionality

@kolaente
Copy link
Member Author

kolaente commented May 9, 2018

@lafriks Filtering issues by assignees (if that's what you mean) works as before, meaning you can show all issues which have at least the one person assigned you choose from a dropdown. It's currently not possible to filter by more than one assignee. I'll probably submit a PR for that once this one is merged.

@lafriks
Copy link
Member

lafriks commented May 9, 2018

@kolaente no I mean there is option to assign user to multiple issues from issue list, does it still work?

@kolaente
Copy link
Member Author

kolaente commented May 9, 2018

@lafriks Yes, this does still work, but only with one user at a time.

@lafriks
Copy link
Member

lafriks commented May 9, 2018

ok that's fine than. I was just wanted to be sure that it is not broken 👍

@kolaente
Copy link
Member Author

kolaente commented May 9, 2018

@lafriks ok, cool.
The CI fail seems unrelated, can someone restart?

@lafriks
Copy link
Member

lafriks commented May 9, 2018

@kolaente already did

@lafriks lafriks merged commit 95f2e2b into go-gitea:master May 9, 2018
@lafriks lafriks added the type/changelog Adds the changelog for a new Gitea version label May 9, 2018
@lunny
Copy link
Member

lunny commented May 10, 2018

@kolaente maybe update docs to add this to feature list and change the comparsion.

aswild added a commit to aswild/gitea that referenced this pull request Jul 6, 2018
@aswild
Merge tag 'v1.5.0-rc1' into wild/v1.5
9b336e6 
* SECURITY
  * Limit uploaded avatar image-size to 4096x3072 by default (go-gitea#4353)
  * Do not allow to reuse TOTP passcode (go-gitea#3878)
* FEATURE
  * Add cli commands to regen hooks & keys (go-gitea#3979)
  * Add support for FIDO U2F (go-gitea#3971)
  * Added user language setting (go-gitea#3875)
  * LDAP Public SSH Keys synchronization (go-gitea#1844)
  * Add topic support (go-gitea#3711)
  * Multiple assignees (go-gitea#3705)
  * Add protected branch whitelists for merging (go-gitea#3689)
  * Global code search support (go-gitea#3664)
  * Add label descriptions (go-gitea#3662)
  * Add issue search via API (go-gitea#3612)
  * Add repository setting to enable/disable health checks (go-gitea#3607)
  * Emoji Autocomplete (go-gitea#3433)
  * Implements generator cli for secrets (go-gitea#3531)
* ENHANCEMENT
  * Add more webhooks support and refactor webhook templates directory (go-gitea#3929)
  * Add new option to allow only OAuth2/OpenID user registration (go-gitea#3910)
  * Add option to use paged LDAP search when synchronizing users (go-gitea#3895)
  * Symlink icons (go-gitea#1416)
  * Improve release page UI (go-gitea#3693)
  * Add admin dashboard option to run health checks (go-gitea#3606)
  * Add branch link in branch list (go-gitea#3576)
  * Reduce sql query times in retrieveFeeds (go-gitea#3547)
  * Option to enable or disable swagger endpoints (go-gitea#3502)
  * Add missing licenses (go-gitea#3497)
  * Reduce repo indexer disk usage (go-gitea#3452)
  * Enable caching on assets and avatars (go-gitea#3376)
  * Add repository search ordered by stars/forks. Forks column in admin repo list (go-gitea#3969)
  * Add Environment Variables to Docker template (go-gitea#4012)
  * LFS: make HTTP auth period configurable (go-gitea#4035)
  * Add config path as an optionial flag when changing pass via CLI (go-gitea#4184)
  * Refactor User Settings sections (go-gitea#3900)
  * Allow square brackets in external issue patterns (go-gitea#3408)
  * Add Attachment API (go-gitea#3478)
  * Add EnableTimetracking option to app settings (go-gitea#3719)
  * Add config option to enable or disable log executed SQL (go-gitea#3726)
  * Shows total tracked time in issue and milestone list (go-gitea#3341)
* TRANSLATION
  * Improve English grammar and consistency (go-gitea#3614)
* DEPLOYMENT
  * Allow Gitea to run as different USER in Docker (go-gitea#3961)
  * Provide compressed release binaries (go-gitea#3991)
  * Sign release binaries (go-gitea#4188)
@kolaente kolaente deleted the multiple-assignees branch July 15, 2018 18:32
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
@delvh delvh removed the type/changelog Adds the changelog for a new Gitea version label Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appleboy appleboy appleboy approved these changes

@lunny lunny lunny approved these changes

@lafriks lafriks lafriks approved these changes

@jonasfranz jonasfranz jonasfranz approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@kolaente @codecov-io @thehowl @jonasfranz @appleboy @lunny @lafriks @tboerger @bkcsoft @delvh