Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nextcloud as auth source #7078

Closed
poVoq opened this issue May 29, 2019 · 10 comments · Fixed by #10562
Closed

Nextcloud as auth source #7078

poVoq opened this issue May 29, 2019 · 10 comments · Fixed by #10562
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Milestone

Comments

@poVoq
Copy link

poVoq commented May 29, 2019

Description

Would be cool if your own Nextcloud instance would work with Oauth2/OIDC like requested by someone else here:
https://discourse.gitea.io/t/nextcloud-as-an-oauth2-authentication-source/1119

When trying to do it with the generic OIDC it results in a 500 error as apparentl the .well-known stuff is not working.

Details on the Nextcloud sinde of things can be found here:
https://docs.nextcloud.com/server/16/admin_manual/configuration_server/oauth2.html
Its a quite new feature and might not work quite like expected.

Thanks for looking into it!

@lafriks
Copy link
Member

lafriks commented May 29, 2019

It should be easy to add as library we use (https://github.com/markbates/goth) does already support nextcloud

@lafriks lafriks added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label May 29, 2019
@stale
Copy link

stale bot commented Jul 28, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Jul 28, 2019
@poVoq
Copy link
Author

poVoq commented Jul 28, 2019

any chance this might still make it into 1.9.0?

@stale stale bot removed the issue/stale label Jul 28, 2019
@lunny lunny added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Jul 29, 2019
@lunny
Copy link
Member

lunny commented Jul 29, 2019

1.9.0 has been freezed and currently there is no PR for this.

@Turakar
Copy link

Turakar commented Aug 15, 2019

I would also be interested in this :)

@fazlerabbi37
Copy link

@Turakar did you start working on this?

@Turakar
Copy link

Turakar commented Oct 1, 2019

Nope, chronic lack of free time ^^ With my small user base, creating separate accounts on both services was ok.

@wioxjk
Copy link

wioxjk commented Nov 12, 2019

I am also very interested in this feature

@githubkoma
Copy link

githubkoma commented Mar 1, 2020

Some more Info:

I already tried to use the GitLab-OAuth2-Template, but that fails because of the following:

  1. This is the first not-working step when getting the user object, as the token is sent as URL-Parameter instead of Bearer-Token in Header:

Gitea Log:
2020/02/29 12:13:52 routers/user/auth.go:590:handleOAuth2SignIn() [E] UserSignIn: Nextcloud responded with a 401 trying to fetch user information

oauth2 gitea not working

1.1 In Comparison how it looks like for Rocket.Chat as OAuth client, where it works:

oauth2 rocketchat working

  1. This is the JSON String that the user-endpoint of nextcloud sends back if authenticated successfuly (i am not sure if the escapes in storageLocation are because of extracting this from wireshark..):
{"ocs":{"meta":{"status":"ok","statuscode":200,"message":"OK"},"data":{"storageLocation":"\/var\/www\/html\/data\/dummy","id":"dummy","lastLogin":1583084839000,"backend":"LDAP","subadmin":["self-registered"],"quota":{"free":2832472,"used":12896168,"total":15728640,"relative":81.99,"quota":15728640},"email":"dummy@gmail.com","phone":"","address":"","website":"","twitter":"","groups":["paid-users"],"language":"en","locale":"","backendCapabilities":{"setDisplayName":false,"setPassword":true},"display-name":"dummy"}}}

techknowlogick added a commit to techknowlogick/gitea that referenced this issue Mar 1, 2020
techknowlogick added a commit that referenced this issue Mar 3, 2020
@lafriks lafriks added this to the 1.12.0 milestone Mar 3, 2020
@githubkoma
Copy link

<3 @lafriks @techknowlogick

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants