BUG: "Propose file change" from UI sends PR to same repo

[guillep2k]

• Gitea version (or commit ref): 1.9.2 + 1.10.0+dev-254-g5fcef38f7
• Git version: 2.22.0
• Operating system: N/A
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL) (N/A)
  • No
  • Not relevant
• Log gist:

Edit: please read summary in this comment.

Description

When I edit a file from the web UI, select Create a new branch for this commit and start a pull request and click on the [Propose file change] button , the new pull request page only lets me request a merge to branches on the same repository, even when it is a fork.

I don't know if this is the intended behavior, but I believe it's a bug.

Screenshots / how to reproduce in try.gitea.io

First I logged into try.gitea.io and went to:

https://try.gitea.io/gitea/gitea

Then I used the [Fork] button and created:

https://try.gitea.io/guillep2k/gitea-fork

Next, I went into editing README.md from master in my fork:

https://try.gitea.io/guillep2k/gitea-fork/_edit/master/README.md

I then created a new branch:

The next page allows me to start the pull request, but the only merge options are for the same repository:

https://try.gitea.io/guillep2k/gitea-fork/compare/master...guillep2k-patch-1

The above URL should have been:

https://try.gitea.io/gitea/gitea/compare/master...guillep2k:guillep2k-patch-1

If I try that URL, the correct page is rendered.

In addition, using the [New pull request] from the home page, some times work (goes to the correct URL) and some times don't (goes to my own fork URL); I couldn't establish a pattern for that.

https://try.gitea.io/guillep2k/gitea-fork/src/branch/guillep2k-patch-1

[guillep2k]

@lunny I think this should be [kind/bug]. The title "Propose file change..." is the option in Gitea that has the bug.

[guillep2k]

OK, I've finally figured out the "problem": the user has no PR access to the source repository, so Gitea is routing the PR to the forked repo:

• repo_fork owner is a collaborator of repo_orig ==> [New pull request] routes to PR creation for repo_orig
• repo_fork owner is not collaborator of repo_orig ==> [New pull request] routes to PR creation for repo_fork (why?)

I don't know if this intended (I don't understand why it is like this), so I'll leave this issue open.

[guillep2k]

Sorry. I really need to read the docs. 🤦‍♂