When starting new stopwatch stop previous if it is still running #10533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
|
I still have this merged in locally. It's proving very useful for my workflow. |
|
I think no one has looked at this because it is still marked WIP. |
|
@bobemoe Could you update the first comment and title, and provide a bit more explanation as to what this is supposed to do and why it is useful. |
bobemoe
changed the title
bobemoe
changed the title
|
@zeripath I've removed WIP so it can get some attention and updated the description, thanks. |
lafriks
approved these changes
Jul 12, 2020
GiteaBot
added
lgtm/need 1
6543
approved these changes
Jul 12, 2020
GiteaBot
added
lgtm/done
lafriks
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it is possible to start tracked time stopwatches on multiple issues at the same time.
The UX feedback of this is a bit confusing, fixes #10529
This PR will prevent multiple stopwatches running by stopping the current stopwatch when another one is started.
Maybe needs a config option if multiple tracking is deemed a required feature. Perhaps even 3 options Multiple Tracking: Prevent|Stop Other|Allow