Skip to content

Fix appearance of unsigned sha box in view_list #10543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 29, 2020
Merged

Fix appearance of unsigned sha box in view_list #10543

merged 2 commits into from
Feb 29, 2020

Conversation

zeripath
Copy link
Contributor

Unfortunately the fix in #10511 was slightly incorrect and placed the
detail box at one level too far out.

Signed-off-by: Andrew Thornton art27@cantab.net

@zeripath
Fix appearance of unsigned sha box in view_list
bf7e0a5 
Unfortunately the fix in go-gitea#10511 was slightly incorrect and placed the
detail box at one level too far out.

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added type/bug topic/ui Change the appearance of the Gitea UI skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. backport/v1.11 labels Feb 29, 2020
@zeripath zeripath added this to the 1.12.0 milestone Feb 29, 2020
@codecov-io
Copy link

codecov-io commented Feb 29, 2020 •
edited
Loading

Codecov Report

Merging #10543 into master will decrease coverage by 0.02%.
The diff coverage is 68.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10543      +/-   ##
==========================================
- Coverage   43.76%   43.74%   -0.03%     
==========================================
  Files         586      586              
  Lines       81764    81764              
==========================================
- Hits        35783    35765      -18     
- Misses      41543    41557      +14     
- Partials     4438     4442       +4
Impacted Files Coverage Δ
modules/structs/user_app.go 0% <ø> (ø) ⬆️
models/issue_label.go 63.04% <ø> (ø) ⬆️
modules/indexer/code/indexer.go 38.02% <10%> (ø) ⬆️
modules/convert/pull.go 71.07% <100%> (ø) ⬆️
routers/api/v1/api.go 76.13% <100%> (ø) ⬆️
models/issue_assignees.go 63.9% <100%> (ø) ⬆️
modules/convert/convert.go 75.88% <100%> (ø) ⬆️
routers/api/v1/repo/label.go 83.71% <100%> (ø) ⬆️
modules/indexer/issues/indexer.go 57.52% <14.28%> (ø) ⬆️
routers/user/home.go 54.89% <53.48%> (ø) ⬆️
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf7e0a5...d1e9bdb. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 29, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 29, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 29, 2020
@zeripath zeripath merged commit 421e7b7 into go-gitea:master Feb 29, 2020
@zeripath zeripath deleted the signbox-redux branch February 29, 2020 13:27
zeripath added a commit to zeripath/gitea that referenced this pull request Feb 29, 2020
@zeripath
Fix appearance of unsigned sha box in view_list (go-gitea#10543)
30627c8 
Unfortunately the fix in go-gitea#10511 was slightly incorrect and placed the
detail box at one level too far out.

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath mentioned this pull request Feb 29, 2020
Merged
lafriks pushed a commit that referenced this pull request Feb 29, 2020
@zeripath
Fix appearance of unsigned sha box in view_list (#10543) (#10544)
3444fa2 
Unfortunately the fix in #10511 was slightly incorrect and placed the
detail box at one level too far out.

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added the backport/done All backports for this PR have been created label Mar 6, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@silverwind silverwind silverwind approved these changes

+1 more reviewer

@jaqra jaqra jaqra approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI type/bug

Projects

None yet

Milestone

1.12.0

Development

Successfully merging this pull request may close these issues.

5 participants

@zeripath @codecov-io @silverwind @jaqra @GiteaBot