Skip to content

Conversation

techknowlogick
Copy link
Member

as title

@techknowlogick techknowlogick added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Mar 3, 2020
@techknowlogick techknowlogick added this to the 1.11.2 milestone Mar 3, 2020
@techknowlogick techknowlogick added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Mar 3, 2020
@zeripath
Copy link
Contributor

zeripath commented Mar 3, 2020

Go 1.13 instead of?

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 3, 2020
@techknowlogick
Copy link
Member Author

It defaults to latest version of XGO, which is currently 1.14 so this PR brings it down to 1.13 support.

@zeripath
Copy link
Contributor

zeripath commented Mar 3, 2020

Hmm could you check if an equivalent to #10583 makes building on go 1.14 work? That might be better than forcibly downgrading to 1.13 (although perhaps the archivist in me likes the idea of forcibly saying what this did build on)

@techknowlogick
Copy link
Member Author

although perhaps the archivist in me likes the idea of forcibly saying what this did build on

I completely agree. We already do this with our docker builds, and so we should keep same approach with our binary builds too.

Your PR will solve one of the issues that 1.14 brings (specifically solves the linked issue), I'll create a patch file that you can apply to your PR that'll catch a few others (that others have yet to run into, but thankfully our tests catch).

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 3, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 3, 2020
@zeripath
Copy link
Contributor

zeripath commented Mar 3, 2020

Make lg-tm work

@zeripath zeripath merged commit 9990430 into release/v1.11 Mar 3, 2020
@lafriks lafriks deleted the techknowlogick-patch-1 branch March 4, 2020 07:47
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants