Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply padding to approval icons on PR list #11622

Merged
merged 3 commits into from
May 26, 2020

Conversation

CirnoT
Copy link
Contributor

@CirnoT CirnoT commented May 25, 2020

Rather minor nitpick, not worthy backporting.

Before:
firefox_2020-05-25_20-36-07
firefox_2020-05-25_20-37-15

After:
firefox_2020-05-25_20-36-31
firefox_2020-05-25_20-37-23

The off-center reject icon is not due to CSS; it's just how it was made.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 25, 2020
@zeripath zeripath added the topic/ui Change the appearance of the Gitea UI label May 25, 2020
@zeripath zeripath added this to the 1.13.0 milestone May 25, 2020
@zeripath
Copy link
Contributor

I think if you could add it it to one of the 1.12 backports that are current it would be useful to have

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 25, 2020
@techknowlogick
Copy link
Member

ping LG-TM

@techknowlogick techknowlogick merged commit b97917a into go-gitea:master May 26, 2020
@CirnoT CirnoT deleted the issue-list-desc branch May 26, 2020 06:12
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: zeripath <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants