Skip to content

Conversation

zeripath
Copy link
Contributor

Previously the settings page would not show the PR section if the repository was empty.

Fix #12788

Signed-off-by: Andrew Thornton art27@cantab.net

Fix go-gitea#12788

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added this to the 1.13.0 milestone Sep 10, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Sep 10, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2020

Codecov Report

Merging #12808 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12808      +/-   ##
==========================================
+ Coverage   43.16%   43.19%   +0.02%     
==========================================
  Files         651      651              
  Lines       72145    72145              
==========================================
+ Hits        31142    31161      +19     
+ Misses      35949    35935      -14     
+ Partials     5054     5049       -5     
Impacted Files Coverage Δ
services/pull/check.go 47.69% <0.00%> (-2.31%) ⬇️
models/error.go 34.81% <0.00%> (-0.52%) ⬇️
models/issue_comment.go 53.75% <0.00%> (-0.16%) ⬇️
models/gpg_key.go 55.40% <0.00%> (+0.58%) ⬆️
services/gitdiff/gitdiff.go 74.48% <0.00%> (+1.63%) ⬆️
modules/charset/charset.go 75.28% <0.00%> (+6.74%) ⬆️
modules/indexer/stats/queue.go 76.47% <0.00%> (+11.76%) ⬆️
modules/indexer/stats/db.go 60.86% <0.00%> (+17.39%) ⬆️
modules/util/timer.go 85.71% <0.00%> (+42.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4eb0a1d...f94e7ef. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 11, 2020
@zeripath zeripath merged commit 7777017 into go-gitea:master Sep 11, 2020
@zeripath zeripath deleted the fix-12788-show-pr-settings-on-empty-repos branch September 11, 2020 12:39
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing advanced settings (PR and project)
7 participants